Re: [U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

2015-08-17 Thread Bin Meng
Hi Simon, On Tue, Aug 11, 2015 at 9:39 PM, Simon Glass wrote: > Update this driver to support driver model. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > drivers/net/e1000.c | 137 > > drivers/net/e1000.h | 4 ++ > 2 fil

Re: [U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

2015-08-13 Thread Simon Glass
Hi Joe, On 11 August 2015 at 11:33, Joe Hershberger wrote: > Hi Simon, > > On Tue, Aug 11, 2015 at 12:17 PM, Simon Glass wrote: >> Hi Joe, >> >> On 11 August 2015 at 09:53, Joe Hershberger >> wrote: >>> Hi Simon, >>> >>> On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass wrote: Update this dri

Re: [U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

2015-08-11 Thread Joe Hershberger
Hi Simon, On Tue, Aug 11, 2015 at 12:17 PM, Simon Glass wrote: > Hi Joe, > > On 11 August 2015 at 09:53, Joe Hershberger wrote: >> Hi Simon, >> >> On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass wrote: >>> Update this driver to support driver model. >>> >>> Signed-off-by: Simon Glass >>> --- >> >

Re: [U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

2015-08-11 Thread Simon Glass
Hi Joe, On 11 August 2015 at 09:53, Joe Hershberger wrote: > Hi Simon, > > On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass wrote: >> Update this driver to support driver model. >> >> Signed-off-by: Simon Glass >> --- > > Acked-by: Joe Hershberger > > ...but a few nits below. > >> >> Changes in v2

Re: [U-Boot] [PATCH v2 3/6] net: e1000: Convert to driver model

2015-08-11 Thread Joe Hershberger
Hi Simon, On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass wrote: > Update this driver to support driver model. > > Signed-off-by: Simon Glass > --- Acked-by: Joe Hershberger ...but a few nits below. > > Changes in v2: None > > drivers/net/e1000.c | 137 > ++