Le 15/04/2011 10:25, Mike Frysinger a écrit :
> On Friday, April 15, 2011 04:13:11 Albert ARIBAUD wrote:
>> What I disagree upon is that just because they're tools we should disregard
>> their warnings
>
> i never said any such thing
> -mike
My bad. What I disagree upon is that just because they'r
On Friday, April 15, 2011 04:13:11 Albert ARIBAUD wrote:
> What I disagree upon is that just because they're tools we should disregard
> their warnings
i never said any such thing
-mike
signature.asc
Description: This is a digitally signed message part.
__
Le 15/04/2011 09:56, Mike Frysinger a écrit :
> On Thursday, April 14, 2011 02:51:42 Albert ARIBAUD wrote:
>> Le 14/04/2011 08:12, Mike Frysinger a écrit :
>>> so i stand by my statement that checkpatch is a tool and does *not* get
>>> the final say. blindly following a tool is good -- if you're b
On Thursday, April 14, 2011 02:51:42 Albert ARIBAUD wrote:
> Le 14/04/2011 08:12, Mike Frysinger a écrit :
> > so i stand by my statement that checkpatch is a tool and does *not* get
> > the final say. blindly following a tool is good -- if you're blind.
>
> When it emits warnings, the C toolchai
Le 14/04/2011 08:12, Mike Frysinger a écrit :
> On Thursday, April 14, 2011 01:58:32 Albert ARIBAUD wrote:
>> Le 14/04/2011 01:30, Mike Frysinger a écrit :
>>> On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
btw. I suspect the change is to keep checkpatch.pl happy about the line
>>
On Thursday, April 14, 2011 01:58:32 Albert ARIBAUD wrote:
> Le 14/04/2011 01:30, Mike Frysinger a écrit :
> > On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
> >> btw. I suspect the change is to keep checkpatch.pl happy about the line
> >> length.
> >
> > also, checkpatch is a tool in
Le 14/04/2011 01:30, Mike Frysinger a écrit :
> On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
>> btw. I suspect the change is to keep checkpatch.pl happy about the line
>> length.
>
> also, checkpatch is a tool in the toolbox. people should not be blindly
> following it, but reviewin
Le 13/04/2011 23:05, Mike Frysinger a écrit :
> On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
>> Le 13/04/2011 05:48, Mike Frysinger a écrit :
if (strchr(dev->name, ' '))
- puts("\nWarning: eth device name has a
On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
> btw. I suspect the change is to keep checkpatch.pl happy about the line
> length.
also, checkpatch is a tool in the toolbox. people should not be blindly
following it, but reviewing its output to see what should be changed and which
On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
> Le 13/04/2011 05:48, Mike Frysinger a écrit :
> >>if (strchr(dev->name, ' '))
> >>
> >> - puts("\nWarning: eth device name has a
> >> space!\n");
> >> + puts("\nWarn
On Wed, Apr 13, 2011 at 1:23 PM, Albert ARIBAUD
wrote:
> Le 13/04/2011 05:48, Mike Frysinger a écrit :
>
>>> if (strchr(dev->name, ' '))
>>> - puts("\nWarning: eth device name has a
>>> space!\n");
>>> + puts("\nWarning: e
Le 13/04/2011 05:48, Mike Frysinger a écrit :
>> if (strchr(dev->name, ' '))
>> -puts("\nWarning: eth device name has a
>> space!\n");
>> +puts("\nWarning: eth device name has a "
>> +
On Tuesday, April 12, 2011 20:46:09 Simon Glass wrote:
> --- a/include/net.h
> +++ b/include/net.h
> +/* Tftp Server IP addr (0 = unknown)*/
> +extern IPaddr_t NetTftpServerIP;
doesnt seem to belong in this patch. guess it bled in from another ?
> --- a/net/eth.c
> +++ b/net/eth.c
>
13 matches
Mail list logo
