Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-29 Thread Marek Vasut
> Hi Marek, > IMO, Simon has already mentioned the reason of using > ALLOC_CACHE_ALIGN_BUFFER, > Please find below my explanation about other doubts. > > On Monday 27 February 2012 10:19 PM, Marek Vasut wrote: > >> As DMA expects the buffers to be equal and larger then > >> cache lines, This align

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-28 Thread puneets
Hi Marek, IMO, Simon has already mentioned the reason of using ALLOC_CACHE_ALIGN_BUFFER, Please find below my explanation about other doubts. On Monday 27 February 2012 10:19 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cachel

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-27 Thread Simon Glass
Hi Marek, On Mon, Feb 27, 2012 at 9:11 AM, Marek Vasut wrote: >> Hi Marek, >> >> On Mon, Feb 27, 2012 at 8:49 AM, Marek Vasut wrote: >> >> As DMA expects the buffers to be equal and larger then >> >> cache lines, This aligns buffers at cacheline. >> >> >> >> Signed-off-by: Puneet Saxena >> >> S

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-27 Thread Marek Vasut
> Hi Marek, > > On Mon, Feb 27, 2012 at 8:49 AM, Marek Vasut wrote: > >> As DMA expects the buffers to be equal and larger then > >> cache lines, This aligns buffers at cacheline. > >> > >> Signed-off-by: Puneet Saxena > >> Signed-off-by: Jim Lin > >> --- > > > > First of all, thanks for this

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-27 Thread Simon Glass
Hi Marek, On Mon, Feb 27, 2012 at 8:49 AM, Marek Vasut wrote: >> As DMA expects the buffers to be equal and larger then >> cache lines, This aligns buffers at cacheline. >> >> Signed-off-by: Puneet Saxena >> Signed-off-by: Jim Lin >> --- >> > > First of all, thanks for this patch, it really hel

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-27 Thread Marek Vasut
> As DMA expects the buffers to be equal and larger then > cache lines, This aligns buffers at cacheline. > > Signed-off-by: Puneet Saxena > Signed-off-by: Jim Lin > --- > First of all, thanks for this patch, it really helps. But, there are a few things that concern me. > Changes for V2: >