Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-06-15 Thread Wolfgang Denk
Dear Aneesh V, In message <4dde54e5.7080...@ti.com> you wrote: > > >> And how do you distinguish between the two cases at the top level > >> Makefile? Using a CONFIG flag or on a per platform basis? > > > > The decision should not be make in the top level makefile, but in > > spl/Makefile. And th

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-06-07 Thread Aneesh V
Hi Wolfgang, On Thursday 26 May 2011 06:55 PM, Aneesh V wrote: > Hi Wolfgang, > > On Tuesday 17 May 2011 06:23 PM, Wolfgang Denk wrote: >> Dear Aneesh V, >> >> In message<4dd26b36.4050...@ti.com> you wrote: >>> >>> And how do you distinguish between the two cases at the top level >>> Makefile? Usi

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-06-02 Thread Aneesh V
Hi Wolfgang, What's your final view on the Makefile structure of SPL. best regards, Aneesh On Thursday 26 May 2011 06:55 PM, Aneesh V wrote: > Hi Wolfgang, > > On Tuesday 17 May 2011 06:23 PM, Wolfgang Denk wrote: >> Dear Aneesh V, >> >> In message<4dd26b36.4050...@ti.com> you wrote: >>> >>> And

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-26 Thread Aneesh V
Hi Wolfgang, On Tuesday 17 May 2011 06:23 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4dd26b36.4050...@ti.com> you wrote: >> >> And how do you distinguish between the two cases at the top level >> Makefile? Using a CONFIG flag or on a per platform basis? > > The decision should not b

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd26b36.4050...@ti.com> you wrote: > > And how do you distinguish between the two cases at the top level > Makefile? Using a CONFIG flag or on a per platform basis? The decision should not be make in the top level makefile, but in spl/Makefile. And this can simply ch

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-17 Thread Aneesh V
Hi Wolfgang, On Tuesday 17 May 2011 01:49 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4dd21fb9.6070...@ti.com> you wrote: >> >> The top-level make rule being the following, we will need a Makefile in >> the board directory, right? >> >> +SPL:$(TIMESTAMP_FILE) $(VERSION_FILE) depe

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd21fb9.6070...@ti.com> you wrote: > > The top-level make rule being the following, we will need a Makefile in > the board directory, right? > > +SPL:$(TIMESTAMP_FILE) $(VERSION_FILE) depend tools > +$(MAKE) -C spl/board/$(BOARDDIR) all Maybe this needs to be

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-17 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 09:18 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4dd134dd.6040...@ti.com> you wrote: >> create mode 100644 spl/board/ti/omap4.mk create mode 100644 spl/board/ti/rules-omap.mk >>> >>> We do you introduce these files? Please omit the

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-16 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd134dd.6040...@ti.com> you wrote: > > >> create mode 100644 spl/board/ti/omap4.mk > >> create mode 100644 spl/board/ti/rules-omap.mk > > > > We do you introduce these files? Please omit them, and use a plain > > Makefile instead. > > I introduced them because 's

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-16 Thread Aneesh V
Hi wolfgang, On Monday 16 May 2011 12:03 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1305472900-4004-10-git-send-email-ane...@ti.com> you wrote: >> Adapted from: nand_spl/board/samsung/smdk6400/Makefile >> >> - Add the SPL makefile for OMAP4430 SDP >> - Add the necessary CONFIG flags

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-15 Thread Wolfgang Denk
Dear Aneesh V, In message <1305472900-4004-10-git-send-email-ane...@ti.com> you wrote: > Adapted from: nand_spl/board/samsung/smdk6400/Makefile > > - Add the SPL makefile for OMAP4430 SDP > - Add the necessary CONFIG flags in the board config file > > Signed-off-by: Aneesh V > --- > V2: > * Ch

Re: [U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

2011-05-15 Thread Wolfgang Denk
Dear Aneesh V, In message <1305472900-4004-10-git-send-email-ane...@ti.com> you wrote: > Adapted from: nand_spl/board/samsung/smdk6400/Makefile > > - Add the SPL makefile for OMAP4430 SDP > - Add the necessary CONFIG flags in the board config file > > Signed-off-by: Aneesh V > --- > V2: > * Ch