Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd2657f.3020...@ti.com> you wrote: > > +struct ch_toc { > +uint32_t section_offset; > +uint32_t section_size; > +uint8_t unused[12]; > +uint8_t section_name[12]; > +} __attribute__ ((__packed__)); > + >

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-17 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 05:18 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4dd0f98a.2040...@ti.com> you wrote: >> @@ -141,6 +141,7 @@ static const table_entry_t uimage_type[] = { { IH_TYPE_FLATDT, "flat_dt","Flat Device Tree", }, >

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-17 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd24cc2.9040...@ti.com> you wrote: > > You mean "__packed__" should be removed from "struct gp_header" alone, > not from the other structs? >From all of them. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-17 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 05:18 PM, Wolfgang Denk wrote: > Dear Aneesh V, > ... > +struct ch_toc { + uint32_t section_offset; + uint32_t section_size; + uint8_t unused[12]; + uint8_t section_name[12]; +} __attribute__ ((__packed__)); + +struct c

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-16 Thread Aneesh V
Hi Mike, On Tuesday 17 May 2011 12:12 AM, Mike Frysinger wrote: > On Monday, May 16, 2011 06:28:40 Aneesh V wrote: >> On Monday 16 May 2011 08:25 AM, Mike Frysinger wrote: >>> On Sunday, May 15, 2011 21:52:53 Mike Frysinger wrote: On Sunday, May 15, 2011 11:21:19 Aneesh V wrote: > +static

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-16 Thread Mike Frysinger
On Monday, May 16, 2011 06:28:40 Aneesh V wrote: > On Monday 16 May 2011 08:25 AM, Mike Frysinger wrote: > > On Sunday, May 15, 2011 21:52:53 Mike Frysinger wrote: > >> On Sunday, May 15, 2011 11:21:19 Aneesh V wrote: > >>> +static void omapimage_print_header(const void *ptr) > >>> +{ > >>> + struc

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-16 Thread Wolfgang Denk
Dear Aneesh V, In message <4dd0f98a.2040...@ti.com> you wrote: > > >> @@ -141,6 +141,7 @@ static const table_entry_t uimage_type[] = { > >>{ IH_TYPE_FLATDT, "flat_dt","Flat Device Tree", }, > >>{ IH_TYPE_KWBIMAGE, "kwbimage", "Kirkwood Boot Image",}, > >>{

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-16 Thread Aneesh V
Hi Mike, On Monday 16 May 2011 08:25 AM, Mike Frysinger wrote: > On Sunday, May 15, 2011 21:52:53 Mike Frysinger wrote: >> On Sunday, May 15, 2011 11:21:19 Aneesh V wrote: >>> +static void omapimage_print_header(const void *ptr) >>> +{ >>> + struct ch_toc *toc = (struct ch_toc *)ptr; >> >> you'r

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-16 Thread Aneesh V
Hi Wolfgang, On Monday 16 May 2011 12:36 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1305472900-4004-2-git-send-email-ane...@ti.com> you wrote: >> From: John Rigby >> >> Signed-off-by: John Rigby >> --- >> common/image.c|1 + >> include/image.h |1 + >> tools/Makefi

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-15 Thread Mike Frysinger
On Sunday, May 15, 2011 21:52:53 Mike Frysinger wrote: > On Sunday, May 15, 2011 11:21:19 Aneesh V wrote: > > +static void omapimage_print_header(const void *ptr) > > +{ > > + struct ch_toc *toc = (struct ch_toc *)ptr; > > you're casting away the void. something is fundamentally broken here. e

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-15 Thread Mike Frysinger
On Sunday, May 15, 2011 11:21:19 Aneesh V wrote: > +static void omapimage_print_header(const void *ptr) > +{ > + struct ch_toc *toc = (struct ch_toc *)ptr; you're casting away the void. something is fundamentally broken here. -mike signature.asc Description: This is a digitally signed messa

Re: [U-Boot] [PATCH v2 01/22] mkimage: Add OMAP boot image support

2011-05-15 Thread Wolfgang Denk
Dear Aneesh V, In message <1305472900-4004-2-git-send-email-ane...@ti.com> you wrote: > From: John Rigby > > Signed-off-by: John Rigby > --- > common/image.c|1 + > include/image.h |1 + > tools/Makefile|2 + > tools/mkimage.c |2 + > tools/mkimage.h |1 + > t