Re: [U-Boot] [PATCH v2] x86: Clean up the FSP support codes

2014-12-16 Thread Simon Glass
Hi Bin, On 16 December 2014 at 20:30, Bin Meng wrote: > Hi Simon, > > On Wed, Dec 17, 2014 at 11:23 AM, Simon Glass wrote: >> Hi Bin, >> >> On 16 December 2014 at 20:12, Bin Meng wrote: >>> Hi Simon, >>> >>> On Tue, Dec 16, 2014 at 1:18 PM, Simon Glass wrote: Hi Bin, On 15 Decem

Re: [U-Boot] [PATCH v2] x86: Clean up the FSP support codes

2014-12-16 Thread Bin Meng
Hi Simon, On Wed, Dec 17, 2014 at 11:23 AM, Simon Glass wrote: > Hi Bin, > > On 16 December 2014 at 20:12, Bin Meng wrote: >> Hi Simon, >> >> On Tue, Dec 16, 2014 at 1:18 PM, Simon Glass wrote: >>> Hi Bin, >>> >>> On 15 December 2014 at 08:03, Bin Meng wrote: This is the follow-on patch t

Re: [U-Boot] [PATCH v2] x86: Clean up the FSP support codes

2014-12-16 Thread Simon Glass
Hi Bin, On 16 December 2014 at 20:12, Bin Meng wrote: > Hi Simon, > > On Tue, Dec 16, 2014 at 1:18 PM, Simon Glass wrote: >> Hi Bin, >> >> On 15 December 2014 at 08:03, Bin Meng wrote: >>> This is the follow-on patch to clean up the FSP support codes: >>> >>> - Remove the _t suffix on the struc

Re: [U-Boot] [PATCH v2] x86: Clean up the FSP support codes

2014-12-16 Thread Bin Meng
Hi Simon, On Tue, Dec 16, 2014 at 1:18 PM, Simon Glass wrote: > Hi Bin, > > On 15 December 2014 at 08:03, Bin Meng wrote: >> This is the follow-on patch to clean up the FSP support codes: >> >> - Remove the _t suffix on the structures defines >> - Use U-Boot's assert() >> - Use standard bool tru

Re: [U-Boot] [PATCH v2] x86: Clean up the FSP support codes

2014-12-15 Thread Simon Glass
Hi Bin, On 15 December 2014 at 08:03, Bin Meng wrote: > This is the follow-on patch to clean up the FSP support codes: > > - Remove the _t suffix on the structures defines > - Use U-Boot's assert() > - Use standard bool true/false > - Remove read_unaligned64() > - Use memcmp() in the compare_guid