Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > Dear Marek Vasut > > > I meant MXS_INCREMENTER_HZ macro and such. > > This change is made to respect Otavio's comment related to this patch > http://lists.denx.de/pipermail/u-boot/2013-February/146906.html I did > also changes to local macro MXS_HW_DIGCTL_MICROSECONDS. > >

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Fadil Berisha
Dear Marek Vasut > I meant MXS_INCREMENTER_HZ macro and such. This change is made to respect Otavio's comment related to this patch http://lists.denx.de/pipermail/u-boot/2013-February/146906.html I did also changes to local macro MXS_HW_DIGCTL_MICROSECONDS. Let me know If you want to submit thos

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Fadil Berisha
Dear Marek Vasut > Also document that you renamed some macros, even if I'd prefer if you pulled > those out into separate patch to make this easier to review. This is documented in comment for patch version v2: "v2 - Updated the struct mxs_timrot_regs so the mapping works for all registers" Since

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > Dear Marek Vasut > > > Also document that you renamed some macros, even if I'd prefer if you > > pulled those out into separate patch to make this easier to review. > > This is documented in comment for patch version v2: > "v2 - Updated the struct mxs_timrot_regs so the map

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > This patch add timer support to i.MX23 and complete bit fields and values > on regs-timrot.h. > Testet on imx23-olinuxino board. Also document that you renamed some macros, even if I'd prefer if you pulled those out into separate patch to make this easier to review. Moreov