Re: [U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows

2010-02-23 Thread Anatolij Gustschin
Hi Stefan, Stefan Roese wrote: > > - printf("mtdparts: %s\n", > > - mtdparts_default ? mtdparts_default : "none"); > > + puts("mtdparts: "); > > + puts(mtdparts_default ? mtdparts_default : "none"); > > + puts("\n"); > > It might make sense to add a comment here, describing wh

Re: [U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows

2010-02-23 Thread Stefan Roese
Hi Anatolij, On Tuesday 23 February 2010 16:18:30 Anatolij Gustschin wrote: > The length of configured MTDPARTS_DEFAULT string > could be greater than console printbuffer size. > Replace printf() by puts() to avoid potential buffer > overflows. > > Signed-off-by: Anatolij Gustschin > --- > Chang