Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-13 Thread Albert ARIBAUD
Prafulla Wadaskar a écrit : >> I can add some comments, although here most of the comments >> would simply >> paraphrase the code one way or the other, e.g. >> + info->device_id = 0xBA; /* device ID of the >> MX29LV400CB is 0xBA */ > > This level documentation is good rather than noth

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-13 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Wednesday, January 13, 2010 6:08 PM > To: Prafulla Wadaskar > Cc: U-Boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH V4 3/3] Add support for the > LaCie ED Mini V2 board ...sn

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-13 Thread Albert ARIBAUD
Prafulla Wadaskar a écrit : >> diff --git a/board/LaCie/edminiv2/config.mk >> +TEXT_BASE = 0x0060 > > ??? As reported earlier, is this okay for you? And do not want to lower it? Fixed for good this time. :) >> diff --git a/board/LaCie/edminiv2/edminiv2.c >> + info->flash_id

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-11 Thread Tom
Albert Aribaud wrote: > This patch adds support for the LaCie ED Mini V2 product > which is based on the Marvell Orion5x SoC. > Current support is limited to console and Flash. > Flash support uses CONFIG_FLASH_CFI_LEGACY as the > Macronix MX29LV400 used on ED Mini V2 is not CFI > compliant (mixes

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-11 Thread Albert ARIBAUD
Hi Prafulla, Prafulla Wadaskar a écrit : > > >> -Original Message- >> From: Albert ARIBAUD [mailto:albert.arib...@free.fr] >> Sent: Monday, January 11, 2010 5:42 PM >> To: Prafulla Wadaskar >> Cc: U-Boot@lists.denx.de >> Subject: Re: [

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-11 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Monday, January 11, 2010 5:42 PM > To: Prafulla Wadaskar > Cc: U-Boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH V4 3/3] Add support for the > LaCie ED Mini V2 board > >

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-11 Thread Albert ARIBAUD
Prafulla Wadaskar a écrit : > I still do not understand who will fectch u-boot binary to TEXT_BASE? > (reported earlier) > Is this flash XIP? Does u-boot binary below 16k? What is the size of flash? > Pls refer my comments for v3 I thought I'd explained that already, haven't I? At power-up a ROM

Re: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED Mini V2 board

2010-01-11 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Albert Aribaud > Sent: Sunday, January 10, 2010 9:34 PM > To: U-Boot@lists.denx.de > Subject: [U-Boot] [PATCH V4 3/3] Add support for the LaCie ED > Mini V2 board > > This patch