Hi all,
Le 17/07/2011 10:26, stefano babic a écrit :
> Am 17/07/2011 08:53, schrieb Igor Grinberg:
Also, in the printf line, you are mixing tabs with spaces
(sorry for not noticing this in previous versions...).
>>> ...and if you want to print something only for debug purposes, the best
Am 17/07/2011 08:53, schrieb Igor Grinberg:
>>> Also, in the printf line, you are mixing tabs with spaces
>>> (sorry for not noticing this in previous versions...).
>> ...and if you want to print something only for debug purposes, the best
>> way is to substitute printf() with debug() and get rid o
On 07/15/11 15:44, Stefano Babic wrote:
> On 07/14/2011 09:02 PM, Igor Grinberg wrote:
>
>>> +#ifdef DEBUG
>>> + if (machid == BI_ARCH_NUMBER_INVALID)
>>> + printf("Warning: machid not set.\n");
>>> +#endif
>>> +
>> Is it essential to enclose that check in #ifdef DEBUG?
>> IMHO, it can
On 07/14/2011 09:02 PM, Igor Grinberg wrote:
>> +#ifdef DEBUG
>> +if (machid == BI_ARCH_NUMBER_INVALID)
>> +printf("Warning: machid not set.\n");
>> +#endif
>> +
>
> Is it essential to enclose that check in #ifdef DEBUG?
> IMHO, it can be useful also with no DEBUG defined,
> so I'
Hi Christopher,
On 07/14/11 21:02, Christopher Harvey wrote:
> Linux cannot boot without it.
>
> Signed-off-by: Christopher Harvey
> ---
>
> V2:
> Used a #define instead of a constant.
> Used a printf instead of a debug.
>
> ---
>
> V3:
> Moved gd->bd->bi_arch_number = BI_ARCH_NUMBER_INVALID; bef
5 matches
Mail list logo
