Re: [U-Boot] [PATCH V2 18/18] arm: mx6: cm_fx6: add sata support

2014-08-19 Thread Nikita Kiryanov
Hi Igor, On 14/08/14 10:10, Igor Grinberg wrote: + +static void cm_fx6_sata_power(int on) Will it be/look better to use bool here? This will create a situation where a bool is passed to a function which takes an int (gpio_direction_output()), and that irks me a little. At least treating ints

Re: [U-Boot] [PATCH V2 18/18] arm: mx6: cm_fx6: add sata support

2014-08-14 Thread Igor Grinberg
Hi Nikita, On 08/10/14 20:13, Nikita Kiryanov wrote: > Add support for SATA. > > Cc: Igor Grinberg > Cc: Stefano Babic > Cc: Tom Rini > Signed-off-by: Nikita Kiryanov > --- > Changes in V2: > - No changes > > board/compulab/cm_fx6/cm_fx6.c | 90 > +