Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-05-18 Thread Andy Fleming
> > I have submit another round of patch, please review it whether it meet > your expectation. Applied, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-05-11 Thread Andy Fleming
On Mon, May 2, 2011 at 9:27 PM, Lei Wen wrote: > > I have submit another round of patch, please review it whether it meet > your expectation. This is just a quick note to say I haven't forgotten about these or other patches in my queue. I'm just buried in other work at the moment. I intend to g

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-05-02 Thread Lei Wen
Hi Andy, On Fri, Apr 29, 2011 at 3:57 PM, Andy Fleming wrote: > On Wed, Apr 27, 2011 at 10:44 PM, Lei Wen wrote: > -                       mmc_init(mmc); +               return 0; +       } else if (strncmp(argv[1], "part", 4) == 0) { +               block_dev_desc_t *mmc_dev

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-30 Thread Mike Frysinger
On Friday, April 29, 2011 06:20:36 Wolfgang Denk wrote: > Andy Fleming wrote: > > It's just that the other way would also be possible. I re-read the > > thread where this was discussed, and while I definitely agree that the > > originally proposed solution was highly error-prone, I think > > *allow

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-29 Thread Wolfgang Denk
Dear Andy Fleming, In message you wrote: > > It's just that the other way would also be possible. I re-read the > thread where this was discussed, and while I definitely agree that the > originally proposed solution was highly error-prone, I think > *allowing* users to do this is fine: > > mmc r

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-29 Thread Andy Fleming
On Wed, Apr 27, 2011 at 10:44 PM, Lei Wen wrote: >>> -                       mmc_init(mmc); >>> +               return 0; >>> +       } else if (strncmp(argv[1], "part", 4) == 0) { >>> +               block_dev_desc_t *mmc_dev; >>> +               struct mmc *mmc = find_mmc_device(mmc_cur_dev); >

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-29 Thread Andy Fleming
On Wed, Apr 27, 2011 at 2:12 PM, Wolfgang Denk wrote: > Dear Andy Fleming, > > In message you wrote: >> >> > From now on, follow the general rule "mmc dev [dev]" to change the >> > mmc command applied device, like ide and usb... > ... >> I'd really prefer if there were still the option to specify

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-27 Thread Lei Wen
Hi Andy, On Thu, Apr 28, 2011 at 1:00 AM, Andy Fleming wrote: > On Fri, Apr 15, 2011 at 9:17 PM, Lei Wen wrote: >> From now on, follow the general rule "mmc dev [dev]" to change the >> mmc command applied device, like ide and usb... >> >> Signed-off-by: Lei Wen >> --- >> Changelog: >> V2: use t

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-27 Thread Wolfgang Denk
Dear Andy Fleming, In message you wrote: > > > From now on, follow the general rule "mmc dev [dev]" to change the > > mmc command applied device, like ide and usb... ... > I'd really prefer if there were still the option to specify the device > in the read/write commands. I appreciate the conveni

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-27 Thread Andy Fleming
On Fri, Apr 15, 2011 at 9:17 PM, Lei Wen wrote: > From now on, follow the general rule "mmc dev [dev]" to change the > mmc command applied device, like ide and usb... > > Signed-off-by: Lei Wen > --- > Changelog: > V2: use the "mmc_cur_dev" to replace explicitly specify the dev num >    in mmc co