Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Alessandro Rubini
> FWIW, I spent _far_ more than 30 minutes on this .. close to a full > day of frustration/banging my head against the wall. [...] I understand the feeling. I'm one of those who suggested (but not required) to put full-asm function in .S files for a reason; I personally think the reboot code may

Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Peter Tyser
On Fri, 2011-03-25 at 11:05 -0700, Tom Warren wrote: > Peter, > > On Fri, Mar 25, 2011 at 10:22 AM, Peter Tyser wrote: > > On Fri, 2011-03-25 at 09:16 -0700, Tom Warren wrote: > >> Peter, > >> > >> On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser wrote: > >> > Hi Tom, > >> > Things look pretty good.

Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Tom Warren
Peter, On Fri, Mar 25, 2011 at 10:22 AM, Peter Tyser wrote: > On Fri, 2011-03-25 at 09:16 -0700, Tom Warren wrote: >> Peter, >> >> On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser wrote: >> > Hi Tom, >> > Things look pretty good.  Minor comments/questions below. >> > >> > >> > >> >> +/* >> >> + * T

Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Peter Tyser
On Fri, 2011-03-25 at 09:16 -0700, Tom Warren wrote: > Peter, > > On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser wrote: > > Hi Tom, > > Things look pretty good. Minor comments/questions below. > > > > > > > >> +/* > >> + * TBD: Move cold_boot() to assembly file. > >> + * Values/offsets of the tab

Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Tom Warren
Peter, On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser wrote: > Hi Tom, > Things look pretty good.  Minor comments/questions below. > > > >> +/* >> + * TBD: Move cold_boot() to assembly file. >> + * Values/offsets of the table vars make this difficult. >> + */ >> + >> +void cold_boot(void) >> +{ >>

Re: [U-Boot] [PATCH V2] arm: Tegra2: add support for A9 CPU init

2011-03-25 Thread Peter Tyser
Hi Tom, Things look pretty good. Minor comments/questions below. > +/* > + * TBD: Move cold_boot() to assembly file. > + * Values/offsets of the table vars make this difficult. > + */ > + > +void cold_boot(void) > +{ > + asm volatile( > + "msrcpsr_c, #0xD3 \n" > +