Re: [U-Boot] [PATCH V2] AT91: Small fix on AT91 USART initialization code

2011-08-02 Thread Hong Xu
Hi Reinhard, On 08/02/2011 05:54 PM, Reinhard Meyer wrote: > Dear Hong Xu, > > > > diff --git a/drivers/serial/atmel_usart.c > b/drivers/serial/atmel_usart.c > > > > index e326b2b..6f9c2de 100644 > > > > --- a/drivers/serial/atmel_usart.c > > > > +++ b/drivers/serial/atmel_usart.c > > > > @@

Re: [U-Boot] [PATCH V2] AT91: Small fix on AT91 USART initialization code

2011-08-02 Thread Reinhard Meyer
Dear Hong Xu, > > > diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c > > > index e326b2b..6f9c2de 100644 > > > --- a/drivers/serial/atmel_usart.c > > > +++ b/drivers/serial/atmel_usart.c > > > @@ -49,17 +49,23 @@ int serial_init(void) > > > { > > > atmel_usart3_t *usa

Re: [U-Boot] [PATCH V2] AT91: Small fix on AT91 USART initialization code

2011-08-01 Thread Hong Xu
Hi Reinhard, On 08/01/2011 10:39 PM, Reinhard Meyer wrote: > Dear Hong Xu, > > Before reset dbgu transmitter, we just wait TXEMPTY to drain the > > transmitter register. If not doing this, we may sometimes see several > > weird characters from DBGU. > > > > A short delay is also added to make

Re: [U-Boot] [PATCH V2] AT91: Small fix on AT91 USART initialization code

2011-08-01 Thread Reinhard Meyer
Dear Hong Xu, > Before reset dbgu transmitter, we just wait TXEMPTY to drain the > transmitter register. If not doing this, we may sometimes see several > weird characters from DBGU. > > A short delay is also added to make sure the new serial settings are > settled. > > Signed-off-by: Hong Xu > ---