Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-07 Thread Minkyu Kang
Dear Jean-Christophe 2009/9/5 Jean-Christophe PLAGNIOL-VILLARD : >> diff --git a/board/samsung/smdkc100/onenand.c >> b/board/samsung/smdkc100/onenand.c > I guess this is not board specific but soc specific > so please move it to drivers/mtd/onenand/ no, this is related with onenand clock. It is

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Jean-Christophe PLAGNIOL-VILLARD
> diff --git a/board/samsung/smdkc100/onenand.c > b/board/samsung/smdkc100/onenand.c I guess this is not board specific but soc specific so please move it to drivers/mtd/onenand/ > new file mode 100644 > index 000..75bb8a9 > --- /dev/null > +++ b/board/samsung/smdkc100/onenand.c > @@ -0,0 +1,9

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Wolfgang Denk
Dear Minkyu Kang, In message <1f3430fb0909040747l5ef9b87wdef31942377c4...@mail.gmail.com> you wrote: > > > Why is this all written in assembly code? > > > > Cannot we use C instead? > > Because of this function called by lowlevel_init (before jumping to C code). > Any problem? > If so, we can me

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Minkyu Kang
Dear Wolfgang, 2009/9/4 Wolfgang Denk > Dear Minkyu Kang, > > In message <4aa0ce4a.3060...@samsung.com> you wrote: > > Add new board SMDKC100 that uses s5pc100 SoC > ... > > diff --git a/board/samsung/smdkc100/mem_setup.S > b/board/samsung/smdkc100/mem_setup.S > > new file mode 100644 > > index

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Wolfgang Denk
Dear Kyungmin Park, In message <9c9fda240909040409u576a7149kd4a4666148bfa...@mail.gmail.com> you wrote: > > >> +++ b/board/samsung/smdkc100/mem_setup.S > > > > Why is this all written in assembly code? > > > > Cannot we use C instead? > > Since it is used at OneNAND IPL. It has size limitation.

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Kyungmin Park
On Fri, Sep 4, 2009 at 7:56 PM, Wolfgang Denk wrote: > Dear Minkyu Kang, > > In message <4aa0ce4a.3060...@samsung.com> you wrote: >> Add new board SMDKC100 that uses s5pc100 SoC > ... >> diff --git a/board/samsung/smdkc100/mem_setup.S >> b/board/samsung/smdkc100/mem_setup.S >> new file mode 100644

Re: [U-Boot] [PATCH 4/4] s5pc1xx: add support SMDKC100 board

2009-09-04 Thread Wolfgang Denk
Dear Minkyu Kang, In message <4aa0ce4a.3060...@samsung.com> you wrote: > Add new board SMDKC100 that uses s5pc100 SoC ... > diff --git a/board/samsung/smdkc100/mem_setup.S > b/board/samsung/smdkc100/mem_setup.S > new file mode 100644 > index 000..a3e692f > --- /dev/null > +++ b/board/samsung/