Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Otavio Salvador
On Mon, Jan 28, 2013 at 5:56 PM, Marek Vasut wrote: > Dear Fabio Estevam, > >> On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador >> >> wrote: >> > +#ifdef CONFIG_CMD_NET >> > +int board_eth_init(bd_t *bis) >> > +{ >> > + /* Power-on Ethernet */ >> > + gpio_direction_output(MX23_PAD_GPM

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador > > wrote: > > +#ifdef CONFIG_CMD_NET > > +int board_eth_init(bd_t *bis) > > +{ > > + /* Power-on Ethernet */ > > + gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1); > > +} > > +#endif > > This function exp

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Fabio Estevam
On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador wrote: > +#ifdef CONFIG_CMD_NET > +int board_eth_init(bd_t *bis) > +{ > + /* Power-on Ethernet */ > + gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1); > +} > +#endif This function expects to return an integer, and there is no re

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Marek Vasut
Dear Otavio Salvador, And again ... NAK Anyway, will the hub function properly if you toggle the GPIO in board_eth_init? I dont think so. [..] Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listin

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Fabio Estevam
On Mon, Jan 28, 2013 at 5:13 PM, Otavio Salvador wrote: >> You should not hardcode a MAC address. > > It does not provide one. Right, but you can not force all olinuxino boards to have the same MAC address, so just remove the MAC setting and each one can set its own. Also, please read: http://w

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Marek Vasut
Dear Otavio Salvador, > On Mon, Jan 28, 2013 at 5:12 PM, Fabio Estevam wrote: > > On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador > > > > wrote: > >> + "ip_dyn=yes\0" \ > >> + "usbethaddr=00:11:22:33:44:55\0" \ > > > > You should not hardcode a MAC address. > > It does not provid

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Otavio Salvador
On Mon, Jan 28, 2013 at 5:12 PM, Fabio Estevam wrote: > On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador > wrote: > >> + "ip_dyn=yes\0" \ >> + "usbethaddr=00:11:22:33:44:55\0" \ > > You should not hardcode a MAC address. It does not provide one. -- Otavio Salvador

Re: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

2013-01-28 Thread Fabio Estevam
On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador wrote: > + "ip_dyn=yes\0" \ > + "usbethaddr=00:11:22:33:44:55\0" \ You should not hardcode a MAC address. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-