Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Marek Vasut
Dear Michal Simek, > On 09/13/2012 02:32 PM, Marek Vasut wrote: > > Dear Michal Simek, > > > >> On 09/13/2012 12:31 PM, Marek Vasut wrote: > >>> Dear Michal Simek, > >>> > On 09/13/2012 11:31 AM, Marek Vasut wrote: > > Dear Michal Simek, > > > > [...] > > > >> +#includ

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Michal Simek
On 09/13/2012 02:32 PM, Marek Vasut wrote: Dear Michal Simek, On 09/13/2012 12:31 PM, Marek Vasut wrote: Dear Michal Simek, On 09/13/2012 11:31 AM, Marek Vasut wrote: Dear Michal Simek, [...] +#include +#include + +ENTRY(lowlevel_init) +mov pc, lr +ENDPROC(lowlevel_init)

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Marek Vasut
Dear Michal Simek, > On 09/13/2012 12:31 PM, Marek Vasut wrote: > > Dear Michal Simek, > > > >> On 09/13/2012 11:31 AM, Marek Vasut wrote: > >>> Dear Michal Simek, > >>> > >>> [...] > >>> > +#include > +#include > + > +ENTRY(lowlevel_init) > +mov pc, lr >

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Michal Simek
On 09/13/2012 12:31 PM, Marek Vasut wrote: Dear Michal Simek, On 09/13/2012 11:31 AM, Marek Vasut wrote: Dear Michal Simek, [...] +#include +#include + +ENTRY(lowlevel_init) +mov pc, lr +ENDPROC(lowlevel_init) inline void lowlevel_init(void) {} works as well and you don't ne

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Marek Vasut
Dear Michal Simek, > On 09/13/2012 11:31 AM, Marek Vasut wrote: > > Dear Michal Simek, > > > > [...] > > > >> +#include > >> +#include > >> + > >> +ENTRY(lowlevel_init) > >> +mov pc, lr > >> +ENDPROC(lowlevel_init) > > > > inline void lowlevel_init(void) {} works as well and you d

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Michal Simek
On 09/13/2012 11:31 AM, Marek Vasut wrote: Dear Michal Simek, [...] +#include +#include + +ENTRY(lowlevel_init) +mov pc, lr +ENDPROC(lowlevel_init) inline void lowlevel_init(void) {} works as well and you don't need the assembly file. :-) yes. The reason why I have done it in

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Michal Simek
On 09/13/2012 11:32 AM, Marek Vasut wrote: Dear Michal Simek, On 08/16/2012 08:30 AM, Michal Simek wrote: Add timer driver. Signed-off-by: Michal Simek --- v2: Move lowlevel_init.S from board to cpu folder Remove XPSS prefix Rename XSCUTIMER -> SCUTIMER Keep timer in zynq fold

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Marek Vasut
Dear Michal Simek, > On 08/16/2012 08:30 AM, Michal Simek wrote: > > Add timer driver. > > > > Signed-off-by: Michal Simek > > > > --- > > v2: Move lowlevel_init.S from board to cpu folder > > > > Remove XPSS prefix > > Rename XSCUTIMER -> SCUTIMER > > > > Keep timer in zynq folder

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-13 Thread Marek Vasut
Dear Michal Simek, [...] > +#include > +#include > + > +ENTRY(lowlevel_init) > +mov pc, lr > +ENDPROC(lowlevel_init) inline void lowlevel_init(void) {} works as well and you don't need the assembly file. > diff --git a/arch/arm/cpu/armv7/zynq/timer.c > b/arch/arm/cpu/armv7/zynq/

Re: [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform

2012-09-12 Thread Michal Simek
On 08/16/2012 08:30 AM, Michal Simek wrote: Add timer driver. Signed-off-by: Michal Simek --- v2: Move lowlevel_init.S from board to cpu folder Remove XPSS prefix Rename XSCUTIMER -> SCUTIMER Keep timer in zynq folder till ARM custodian comments it. --- arch/arm/cpu/armv7/zynq/Mak