Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-30 Thread Mike Frysinger
On Sat, Apr 30, 2011 at 10:34, Tabi Timur-B04825 wrote: > Mike Frysinger wrote: >> so implement this in your board file in misc_init_r or board_eth_init.  have >> the code do something like: >>       uchar enetaddr[6]; >>       if (!eth_getenv_enetaddr("ethaddr", enetaddr)) { >>               /* ..

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-30 Thread Tabi Timur-B04825
Mike Frysinger wrote: > so implement this in your board file in misc_init_r or board_eth_init. have > the code do something like: > uchar enetaddr[6]; > if (!eth_getenv_enetaddr("ethaddr", enetaddr)) { > /* ... read current MAC out of the driver's registers ... */ >

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-29 Thread Mike Frysinger
On Thursday, March 17, 2011 15:46:56 Michael Spang wrote: > while (!eth_getenv_enetaddr(s, dev->enetaddr)) { this logic in the mvgbe is plain broken. it should not be touching the env at all. if there is no eeprom to read, then the mvgbe driver should leave dev- >enetaddr alone.

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-29 Thread Mike Frysinger
On Tuesday, April 26, 2011 00:23:47 Michael Spang wrote: > On Mon, Apr 25, 2011 at 7:37 AM, Tabi Timur-B04825 wrote: > > On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk wrote: > >> And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to > >> the README. > > > > We have something simil

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-25 Thread Michael Spang
On Mon, Apr 25, 2011 at 7:37 AM, Tabi Timur-B04825 wrote: > On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk wrote: > >> And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to >> the README. > > We have something similar already on Freescale parts, but it does > sometimes cause probl

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-25 Thread Michael Spang
On Sun, Apr 24, 2011 at 7:50 PM, Wolfgang Denk wrote: > Dear Michael Spang, > > In message <1300391223-11879-3-git-send-email-msp...@csclub.uwaterloo.ca> you > wrote: >> The MVGBE driver either gets the MAC from the environment, or invents >> one. This allows the driver to leave the existing addr

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-25 Thread Tabi Timur-B04825
On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk wrote: > And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to > the README. We have something similar already on Freescale parts, but it does sometimes cause problems. If the environment ethaddr is already set, it is left alone. O

Re: [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address

2011-04-24 Thread Wolfgang Denk
Dear Michael Spang, In message <1300391223-11879-3-git-send-email-msp...@csclub.uwaterloo.ca> you wrote: > The MVGBE driver either gets the MAC from the environment, or invents > one. This allows the driver to leave the existing address alone in > case it is initialized before U-Boot starts. Who