Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-18 Thread Wolfgang Denk
Dear Marek Vasut, In message <201101182032.33444.marek.va...@gmail.com> you wrote: > > > > +/*** > > > *** > > > > I have not checked before, but this is not the coding style for > > multiline comments. > > Well it's more of

Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-18 Thread Marek Vasut
On Sunday 16 January 2011 16:21:34 Stefano Babic wrote: > On 01/13/2011 06:27 PM, Marek Vasut wrote: > > As for the PMIC, other boards don't use any #defines for those constants > > either, which obviously doens't mean it's right. > > Well, this is not true. You use in yourd board a lot of these c

Re: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Preliminary board support

2011-01-16 Thread Stefano Babic
On 01/13/2011 06:27 PM, Marek Vasut wrote: > As for the PMIC, other boards don't use any #defines for those constants > either, > which obviously doens't mean it's right. Well, this is not true. You use in yourd board a lot of these constants. There are only a few of them that are not used and >