Re: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support

2012-12-06 Thread Marek Vasut
Dear Simon Glass, > Hi Marek, > > On Thu, Dec 6, 2012 at 10:02 AM, Marek Vasut wrote: > > Dear Simon Glass, > > > > [...] > > > >> > [...] > >> > > >> > error output should be really puts() or printf() ... > >> > >> Ick that bloats the code badly for an uncommon case. Would really > >> prefe

Re: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support

2012-12-06 Thread Simon Glass
Hi Marek, On Thu, Dec 6, 2012 at 10:02 AM, Marek Vasut wrote: > Dear Simon Glass, > > [...] > >> > [...] >> > >> > error output should be really puts() or printf() ... >> >> Ick that bloats the code badly for an uncommon case. Would really >> prefer to avoid this. > > What do you mean? Are you sa

Re: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support

2012-12-06 Thread Marek Vasut
Dear Simon Glass, [...] > > [...] > > > > error output should be really puts() or printf() ... > > Ick that bloats the code badly for an uncommon case. Would really > prefer to avoid this. What do you mean? Are you saying this debug() is correct and this is triggered often? How come? > > You

Re: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support

2012-12-06 Thread Simon Glass
Hi Marek, On Thu, Dec 6, 2012 at 9:39 AM, Marek Vasut wrote: > Dear Rajeshwari Shinde, > >> Adding fdt support to ehci-exynos in order to parse >> register base addresses from the device node. >> >> Signed-off-by: Vivek Gautam >> Signed-off-by: Rajeshwari Shinde >> --- >> Chnages in V2: >>

Re: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support

2012-12-06 Thread Marek Vasut
Dear Rajeshwari Shinde, > Adding fdt support to ehci-exynos in order to parse > register base addresses from the device node. > > Signed-off-by: Vivek Gautam > Signed-off-by: Rajeshwari Shinde > --- > Chnages in V2: > - Removed checkpatch errors. > drivers/usb/host/ehci-exynos.c | 59 >