Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios

2011-05-12 Thread Gilles Chanteperdrix
On 05/13/2011 07:31 AM, John Rigby wrote: >> >> I am going to fix this and resend another round of patches. But, it this >> the only thing I should fix? >> > My comment was not a complete review only a comment about sharing. I got that, I am just trying to get more comments before I send another r

Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios

2011-05-12 Thread John Rigby
> > I am going to fix this and resend another round of patches. But, it this > the only thing I should fix? > My comment was not a complete review only a comment about sharing. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/list

Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios

2011-05-12 Thread Gilles Chanteperdrix
On 05/10/2011 04:08 PM, John Rigby wrote: > On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix > wrote: >> Copied from omap3. > I have not looked at the code but if it truly is a copy (other than > some base addresses) is there a way to share with omap3? I am going to fix this and resend anoth

Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios

2011-05-10 Thread Gilles Chanteperdrix
On 05/10/2011 04:08 PM, John Rigby wrote: > On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix > wrote: >> Copied from omap3. > I have not looked at the code but if it truly is a copy (other than > some base addresses) is there a way to share with omap3? Yes, probably. The linux code is full o

Re: [U-Boot] [PATCH 1/3] omap4: add support for gpios

2011-05-10 Thread John Rigby
On Mon, May 9, 2011 at 11:04 PM, Gilles Chanteperdrix wrote: > Copied from omap3. I have not looked at the code but if it truly is a copy (other than some base addresses) is there a way to share with omap3? --john ___ U-Boot mailing list U-Boot@lists.de