Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-09 Thread Scott Wood
On Fri, Nov 06, 2009 at 05:15:31PM +0530, Amul Kumar Saha wrote: > This patch adds support for Flex-OneNAND devices. > > Signed-off-by: Rohit Hagargundgi > Signed-off-by: Amul Kumar Saha > --- > drivers/mtd/onenand/onenand_base.c | 742 > +++- > drivers/mtd/on

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-05 Thread Scott Wood
On Wed, Nov 04, 2009 at 10:37:17AM +0530, Amul Kumar Saha wrote: > This patch adds support for Flex-OneNAND devices. > > Signed-off-by: Rohit Hagargundgi > Signed-off-by: Amul Kumar Saha A couple 64-bit offset nits... > +static void flexonenand_get_size(struct mtd_info *mtd) > +{ > + struc

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-04 Thread Kyungmin Park
H Scott, If you you don't mind, I'm okay to this patch. Can you merge it? Thank you, Kyungmin Park On Wed, Nov 4, 2009 at 2:00 PM, Amul Kumar Saha wrote: > Hi Scott, > >>> +static loff_t flexonenand_addr(struct onenand_chip *this, int block) >>> +{ >>> + loff_t ofs = 0; >>> + int die = 0, bound

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-03 Thread Amul Kumar Saha
Hi Scott, >> +static loff_t flexonenand_addr(struct onenand_chip *this, int block) >> +{ >> + loff_t ofs = 0; >> + int die = 0, boundary; >> + >> + if (ONENAND_IS_DDP(this) && block >= this->density_mask) { >> + block -= this->density_mask; >> + die = 1; >> + ofs = this->diesize[0]; >> + } >> + >>

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-11-03 Thread Amul Kumar Saha
This patch adds support for Flex-OneNAND devices. Signed-off-by: Rohit Hagargundgi Signed-off-by: Amul Kumar Saha --- drivers/mtd/onenand/onenand_base.c | 740 +++- drivers/mtd/onenand/onenand_bbt.c | 14 drivers/mtd/onenand/onenand_uboot.c |4 include/

Re: [U-Boot] [PATCH 1/3] [OneNAND] Flex-OneNAND driver support

2009-09-28 Thread Scott Wood
On Thu, Sep 24, 2009 at 11:43:47AM +0530, Amul Kumar Saha wrote: > +static loff_t flexonenand_addr(struct onenand_chip *this, int block) > +{ > + loff_t ofs = 0; > + int die = 0, boundary; > + > + if (ONENAND_IS_DDP(this) && block >= this->density_mask) { > + block -= this->