Re: [U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

2011-12-13 Thread Jason Hobbs
On Fri, Dec 09, 2011 at 03:45:44PM -0500, Wolfgang Denk wrote: > Dear Jason, > > In message <20111209134819.GA26840@jhobbs-laptop> you wrote: > > > > > default: > > > printf("Ignoring malformed menu command: %.*s\n", > > > (int)(*c - s), s); > > > + e

Re: [U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

2011-12-09 Thread Wolfgang Denk
Dear Jason, In message <20111209134819.GA26840@jhobbs-laptop> you wrote: > > > default: > > printf("Ignoring malformed menu command: %.*s\n", > > (int)(*c - s), s); > > + err = -1; > > err should either be set to 0 here, or initialized to 0 a

Re: [U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

2011-12-09 Thread Jason Hobbs
Dear Wolfgang, On Fri, Dec 09, 2011 at 06:14:23AM -0500, Wolfgang Denk wrote: > Fix: > cmd_pxe.c: In function 'parse_pxefile_top': > cmd_pxe.c:941:5: warning: 'err' may be used uninitialized in this > function [-Wuninitialized] > cmd_pxe.c:921:6: note: 'err' was declared here > > Signed-off-by: W