Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-28 Thread Wolfgang Denk
Dear Julien, In message you wrote: > > > So if we add support to read from stdin instead from a file where we > > pass the file name as an argument, we should probably do this in a > > consistent way. It would be a frustrating experience to the end user > > to learn that he can use stdin here b

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-28 Thread Julien Castets
On Sun, Sep 28, 2014 at 8:49 AM, Wolfgang Denk wrote: > The case where mkimage is taking a single input file is quickly > becoming a rare corner case. > > The recommended way to build U-Boot images is (and has been for years, > even though marketing for this has been poor) to build FIT images. In

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Julien, In message you wrote: > > Without the patch, with mmap: Thanks for the numbers. So these indeed make no real difference. > I understand the use case, in its globality, is pretty exotic. > However, I don't really get why giving /dev/stdin as input is. The case where mkimage is

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Julien Castets
Thanks for your comments, On Sat, Sep 27, 2014 at 11:56 PM, Wolfgang Denk wrote: > Can you please provide values for the size of the binary and the > execution time? Without the patch, with mmap: $> dd if=/dev/zero of=test bs=1M count=10 $> time ./mkimage -A arm -O linux -a 0 -e 0 -T script -C n

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Marek, In message <201409280001.26383.ma...@denx.de> you wrote: > > > Can you please provide values for the size of the binary and the > > execution time? > > > > It's not really critical, but I'd like to understand the impact of > > your changes. You use case is pretty exotic, so it seems

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Marek Vasut
On Saturday, September 27, 2014 at 11:56:55 PM, Wolfgang Denk wrote: Hello Wolfgang, > Dear Julien, > > In message you wrote: > > I'm not sure to understand what you mean. In both cases, the file is > > copied. > > > > What is bothering you? > > I asked: > | What is the size and performance i

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Julien, In message you wrote: > > I'm not sure to understand what you mean. In both cases, the file is copied. > > What is bothering you? I asked: | What is the size and performance impact of the suggested change for | typical use cases? Can you please provide values for the size of th

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Julien Castets
On Sep 27, 2014 8:24 PM, "Wolfgang Denk" > OK, so you don't have any real data, but make a very specific > statement: "exactly the same." > > Sorry, but this is not an answer I'm going to buy. I'm not sure to understand what you mean. In both cases, the file is copied. What is bothering you?

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Julien, In message you wrote: > > > I don't believe you. Sizes rare certainly not identical, and neither > > is the performance. Did you do any real measurements? > > mmap is useful when you need to make random access in a file, or to > optimize memory: when a file is mmapped, the kernel

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Julien Castets
On Sat, Sep 27, 2014 at 3:25 PM, Wolfgang Denk wrote: > Sorry, but I don't understand this. Where are the image(s) coming > from, then? Who or what is feeding the pipe? Sorry, I wrote quickly. In my situation: - I have a Python implementation of a TFTP server - when the file named "uboot.boot

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Julien, In message you wrote: > On Sat, Sep 27, 2014 at 2:54 PM, Wolfgang Denk wrote: > > What would be the benefit of doing so? Do you have an example for a > > practical use case where this makes sense? > > In my case, I have a TFTP server that dyncamically generates uboot > bootfiles

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Julien Castets
On Sat, Sep 27, 2014 at 2:54 PM, Wolfgang Denk wrote: > What would be the benefit of doing so? Do you have an example for a > practical use case where this makes sense? In my case, I have a TFTP server that dyncamically generates uboot bootfiles when a specific file is requested. The input templ

Re: [U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

2014-09-27 Thread Wolfgang Denk
Dear Julien, In message you wrote: > > I would like to give /dev/stdin to the flag -d of mkimage. The only What would be the benefit of doing so? Do you have an example for a practical use case where this makes sense? > This patch replaces the use of mmap(2) with read(2). If accepted, I > co