Re: [U-Boot] [PATCH] tools/kwbimage: Fix compilation warning

2014-10-27 Thread Stefan Roese
Hi Wolfgang, On 27.10.2014 14:34, Wolfgang Denk wrote: + switch (version) { + /* +* Fallback to version 0 is no version is provided in the +* cfg file +*/ + case -1: ... What exactly is the difference between return cod

Re: [U-Boot] [PATCH] tools/kwbimage: Fix compilation warning

2014-10-27 Thread Wolfgang Denk
Dear Stefan, In message <544e4412.60...@denx.de> you wrote: > > >> + switch (version) { > >> + /* > >> + * Fallback to version 0 is no version is provided in the > >> + * cfg file > >> + */ > >> + case -1: ... > > What exactly is the difference between re

Re: [U-Boot] [PATCH] tools/kwbimage: Fix compilation warning

2014-10-27 Thread Stefan Roese
Hi Wolfgang, On 27.10.2014 13:57, Wolfgang Denk wrote: tools/kwbimage.c: In function ‘kwbimage_set_header’: tools/kwbimage.c:784:8: warning: ‘headersz’ may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(ptr, image, headersz); ^ Instead of using multiple if sta

Re: [U-Boot] [PATCH] tools/kwbimage: Fix compilation warning

2014-10-27 Thread Wolfgang Denk
Dear Stefan, In message <1414412953-25615-1-git-send-email...@denx.de> you wrote: > This patch fixes a compilation warning of kwbimage.c: > > tools/kwbimage.c: In function ‘kwbimage_set_header’: > tools/kwbimage.c:784:8: warning: ‘headersz’ may be used uninitialized in this > function [-Wmaybe-u