Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-28 Thread Tom Rini
On Wed, Nov 28, 2018 at 10:08:51AM +0100, Wolfgang Denk wrote: > Dear Simon, > > In message <1707f08a-4844-979c-716f-9ee8da29c...@gmail.com> you wrote: > > > > I also thought about that. I voted against to have less config options. > > Yes, I can understand this. Actually I have to admit that I

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-28 Thread Simon Goldschmidt
Am Mi., 28. Nov. 2018, 10:44 hat Wolfgang Denk geschrieben: > Dear Simon, > > In message <54b881d1-39d5-8b3c-8fbf-1c249349d...@gmail.com> you wrote: > > > > That still sounds like an interesting feature! Although it might be > > difficult to implement with all the different unzip algorithms we ha

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-28 Thread Wolfgang Denk
Dear Simon, In message <54b881d1-39d5-8b3c-8fbf-1c249349d...@gmail.com> you wrote: > > That still sounds like an interesting feature! Although it might be > difficult to implement with all the different unzip algorithms we have > to add a CRC check... > > But I do not see it in the current U-Boo

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-28 Thread Simon Goldschmidt
On 28.11.2018 10:08, Wolfgang Denk wrote: Dear Simon, In message <1707f08a-4844-979c-716f-9ee8da29c...@gmail.com> you wrote: I also thought about that. I voted against to have less config options. Yes, I can understand this. Actually I have to admit that I cannot think of a god reason to have

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-28 Thread Wolfgang Denk
Dear Simon, In message <1707f08a-4844-979c-716f-9ee8da29c...@gmail.com> you wrote: > > I also thought about that. I voted against to have less config options. Yes, I can understand this. Actually I have to admit that I cannot think of a god reason to have CRC support in SPL for other purposes,

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-27 Thread Simon Goldschmidt
On 27.11.2018 15:57, Wolfgang Denk wrote: Dear Simon, In message <20181124124641.6605-1-simon.k.r.goldschm...@gmail.com> you wrote: SPL currently does not check uImage CRCs when loading U-Boot. This patch adds checking the uImage CRC when SPL loads U-Boot. It does this by reusing the existing

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-27 Thread Wolfgang Denk
Dear Simon, In message <20181124124641.6605-1-simon.k.r.goldschm...@gmail.com> you wrote: > SPL currently does not check uImage CRCs when loading U-Boot. > > This patch adds checking the uImage CRC when SPL loads U-Boot. It does > this by reusing the existing config option SPL_CRC32_SUPPORT to al

Re: [U-Boot] [PATCH] spl: implement CRC check on U-Boot uImage

2018-11-26 Thread Simon Glass
On Sat, 24 Nov 2018 at 05:46, Simon Goldschmidt wrote: > > SPL currently does not check uImage CRCs when loading U-Boot. > > This patch adds checking the uImage CRC when SPL loads U-Boot. It does > this by reusing the existing config option SPL_CRC32_SUPPORT to allow > leaving out the CRC check on