Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Ben Warren
Valentin, On Thu, Apr 22, 2010 at 12:53 PM, Valentin Yakovenkov wrote: > 22.04.2010 23:43, Mike Frysinger wrote: > > i would send the patch again with this info in the changelog. however, at >> least on my board, i see no speed difference with this patch. i get about >> 2.8MiB/s on my bf548-ez

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Valentin Yakovenkov
22.04.2010 23:43, Mike Frysinger wrote: i would send the patch again with this info in the changelog. however, at least on my board, i see no speed difference with this patch. i get about 2.8MiB/s on my bf548-ezkit with and without your change. so, it doesnt break anything that i can see, nor

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Mike Frysinger
On Thursday 22 April 2010 15:12:19 Valentin Yakovenkov wrote: > 21.04.2010 23:52, Mike Frysinger wrote: > >>> Wrong alignment in smc911x driver when reading a frame from fifo. > >>> Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't > >>> need to add anything here. > >> > >> I k

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Valentin Yakovenkov
21.04.2010 23:52, Mike Frysinger wrote: Wrong alignment in smc911x driver when reading a frame from fifo. Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't need to add anything here. I know you use this driver a lot. Please comment on this patch. i really havent a clue wh

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-21 Thread Mike Frysinger
On Wednesday 21 April 2010 13:52:27 Ben Warren wrote: > On 4/21/2010 12:56 AM, Valentin Yakovenkov wrote: > > Wrong alignment in smc911x driver when reading a frame from fifo. > > Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't > > need to add anything here. > > I know you use

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-21 Thread Ben Warren
Mike, I know you use this driver a lot. Please comment on this patch. On 4/21/2010 12:56 AM, Valentin Yakovenkov wrote: > Wrong alignment in smc911x driver when reading a frame from fifo. > Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't > need to add anything here. > > Sig