Re: [U-Boot] [PATCH] sandbox: add a sandbox timer and basic test

2015-10-29 Thread Thomas Chou
Hi Simon, On 2015年10月30日 07:43, Simon Glass wrote: Can you please split out the board_f.c change into a separate commit? But the sandbox will fail (with seg fault or hang) without the change in board_f.c . Is this alright? What if you put that commit first in the series? Good idea. Thank

Re: [U-Boot] [PATCH] sandbox: add a sandbox timer and basic test

2015-10-29 Thread Simon Glass
Hi Thomas, On 29 October 2015 at 17:27, Thomas Chou wrote: > Hi Simon, > > On 10/30/2015 01:16 AM, Simon Glass wrote: >> >> Hi Thomas, >> >> On 22 October 2015 at 07:25, Thomas Chou wrote: >>> >>> Add a sandbox timer which get time from host os and a basic >>> test. >>> >>> Signed-off-by: Thomas

Re: [U-Boot] [PATCH] sandbox: add a sandbox timer and basic test

2015-10-29 Thread Thomas Chou
Hi Simon, On 10/30/2015 01:16 AM, Simon Glass wrote: Hi Thomas, On 22 October 2015 at 07:25, Thomas Chou wrote: Add a sandbox timer which get time from host os and a basic test. Signed-off-by: Thomas Chou --- arch/sandbox/dts/sandbox.dts | 4 ++ board/sandbox/sandbox

Re: [U-Boot] [PATCH] sandbox: add a sandbox timer and basic test

2015-10-29 Thread Simon Glass
Hi Thomas, On 22 October 2015 at 07:25, Thomas Chou wrote: > Add a sandbox timer which get time from host os and a basic > test. > > Signed-off-by: Thomas Chou > --- > arch/sandbox/dts/sandbox.dts | 4 ++ > board/sandbox/sandbox.c | 2 + > common/b