Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-04 Thread Marek Vasut
On Tuesday, February 04, 2014 at 01:57:48 AM, Eric Nelson wrote: [...] > > Hope it helps :) Sometimes you need to do a few cycles until the hardware > > hangs. I found this out when I was debugging another custom board here. > > I think we will have a rock-solid PCIe implementation on MX6 for 3.14

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Eric Nelson
On 02/03/2014 04:34 PM, Marek Vasut wrote: On Monday, February 03, 2014 at 09:54:33 PM, Eric Nelson wrote: Hi Marek, On 02/03/2014 01:16 PM, Marek Vasut wrote: On Monday, February 03, 2014 at 08:57:30 PM, Eric Nelson wrote: [...] I like having this bit included, but do you need to attribute

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Marek Vasut
On Monday, February 03, 2014 at 09:54:33 PM, Eric Nelson wrote: > Hi Marek, > > On 02/03/2014 01:16 PM, Marek Vasut wrote: > > On Monday, February 03, 2014 at 08:57:30 PM, Eric Nelson wrote: > > > > [...] > > I like having this bit included, but do you need to attribute copyright > for this bloc

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Eric Nelson
Hi Marek, On 02/03/2014 01:16 PM, Marek Vasut wrote: On Monday, February 03, 2014 at 08:57:30 PM, Eric Nelson wrote: [...] I like having this bit included, but do you need to attribute copyright for this block? " 6.6.1. Conventional Reset Conventional Reset includes all reset mechanisms o

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Marek Vasut
On Monday, February 03, 2014 at 08:57:30 PM, Eric Nelson wrote: [...] > > " > > 6.6.1. Conventional Reset > > > > Conventional Reset includes all reset mechanisms other than Function > > Level Reset. There are two categories of Conventional Resets: > > Fundamental Reset and resets that are not F

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Stefano Babic
Hi Marek, On 03/02/2014 19:17, Marek Vasut wrote: Well ... SL and N6X both. For all I care, we can have #define MX6_PCIE_RESET_GPIO and if that's not defined, puke out this warning. And ultimatelly let this function be overriden anyway in case people used some GPIO expander or whatnot. So the c

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Eric Nelson
Hi Marek, On 02/03/2014 12:33 PM, Marek Vasut wrote: On Monday, February 03, 2014 at 07:40:09 PM, Eric Nelson wrote: [...] Well ... SL and N6X both. For all I care, we can have #define MX6_PCIE_RESET_GPIO and if that's not defined, puke out this warning. And ultimatelly let this function be o

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Marek Vasut
On Monday, February 03, 2014 at 07:40:09 PM, Eric Nelson wrote: [...] > > Well ... SL and N6X both. For all I care, we can have #define > > MX6_PCIE_RESET_GPIO and if that's not defined, puke out this warning. And > > ultimatelly let this function be overriden anyway in case people used > > some

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Eric Nelson
Hi Marek, On 02/03/2014 11:17 AM, Marek Vasut wrote: On Monday, February 03, 2014 at 12:56:04 PM, Stefano Babic wrote: Hi Marek, sorry for late answer. On 28/01/2014 20:32, Marek Vasut wrote: On Tuesday, January 28, 2014 at 04:06:12 PM, Stefano Babic wrote: Hi Marek, On 24/01/2014 16:25, M

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Marek Vasut
On Monday, February 03, 2014 at 12:56:04 PM, Stefano Babic wrote: > Hi Marek, > > sorry for late answer. > > On 28/01/2014 20:32, Marek Vasut wrote: > > On Tuesday, January 28, 2014 at 04:06:12 PM, Stefano Babic wrote: > >> Hi Marek, > >> > >> On 24/01/2014 16:25, Marek Vasut wrote: > >>> Add a

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-02-03 Thread Stefano Babic
Hi Marek, sorry for late answer. On 28/01/2014 20:32, Marek Vasut wrote: > On Tuesday, January 28, 2014 at 04:06:12 PM, Stefano Babic wrote: >> Hi Marek, >> >> On 24/01/2014 16:25, Marek Vasut wrote: >>> Add a callback so that a board can implement it's own specific routine to >>> toggle the port

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-01-30 Thread Tim Harvey
On Fri, Jan 24, 2014 at 7:25 AM, Marek Vasut wrote: > Add a callback so that a board can implement it's own specific routine to > toggle the port's nRESET line. > > Signed-off-by: Marek Vasut > Cc: Stefano Babic > --- > drivers/pci/pcie_imx.c | 12 +--- > 1 file changed, 9 insertions(+)

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-01-28 Thread Marek Vasut
On Tuesday, January 28, 2014 at 04:06:12 PM, Stefano Babic wrote: > Hi Marek, > > On 24/01/2014 16:25, Marek Vasut wrote: > > Add a callback so that a board can implement it's own specific routine to > > toggle the port's nRESET line. > > > > Signed-off-by: Marek Vasut > > Cc: Stefano Babic > >

Re: [U-Boot] [PATCH] pci: mx6: Implement reset callback

2014-01-28 Thread Stefano Babic
Hi Marek, On 24/01/2014 16:25, Marek Vasut wrote: > Add a callback so that a board can implement it's own specific routine to > toggle the port's nRESET line. > > Signed-off-by: Marek Vasut > Cc: Stefano Babic > --- > drivers/pci/pcie_imx.c | 12 +--- > 1 file changed, 9 insertions(+),