Re: [U-Boot] [PATCH] nios2: nios2-generic: do not allocate rx buf in net.c

2015-11-05 Thread Thomas Chou
Hi Marek, On 2015年11月06日 09:40, Marek Vasut wrote: On Friday, November 06, 2015 at 12:47:13 AM, Thomas Chou wrote: Hi Marek, Hi! On 2015年11月06日 00:16, Marek Vasut wrote: On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote: Do not allocate rx buf in net.c, because altera_tse a

Re: [U-Boot] [PATCH] nios2: nios2-generic: do not allocate rx buf in net.c

2015-11-05 Thread Marek Vasut
On Friday, November 06, 2015 at 12:47:13 AM, Thomas Chou wrote: > Hi Marek, Hi! > On 2015年11月06日 00:16, Marek Vasut wrote: > > On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote: > >> Do not allocate rx buf in net.c, because altera_tse allocates > >> its own rx buf in driver. This c

Re: [U-Boot] [PATCH] nios2: nios2-generic: do not allocate rx buf in net.c

2015-11-05 Thread Thomas Chou
Hi Marek, On 2015年11月06日 00:16, Marek Vasut wrote: On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote: Do not allocate rx buf in net.c, because altera_tse allocates its own rx buf in driver. This can save 6KB memory. Signed-off-by: Thomas Chou Shouldn't we instead fix the alte

Re: [U-Boot] [PATCH] nios2: nios2-generic: do not allocate rx buf in net.c

2015-11-05 Thread Marek Vasut
On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote: > Do not allocate rx buf in net.c, because altera_tse allocates > its own rx buf in driver. This can save 6KB memory. > > Signed-off-by: Thomas Chou Shouldn't we instead fix the altera driver to use the pre-allocated buffer ? Bes