Re: [U-Boot] [PATCH] nios2: add gpio based status led driver

2010-04-20 Thread Thomas Chou
On 04/21/2010 12:19 AM, Scott McNutt wrote: > > I don't think the Altera board tree is an appropriate place for > code that supports custom logic blocks. If an Altera distribution > provided a design that included this custom block in one of their > board designs then it would probably be fine. > >

Re: [U-Boot] [PATCH] nios2: add gpio based status led driver

2010-04-20 Thread Scott McNutt
Thomas Chou wrote: > On 04/20/2010 09:19 PM, Scott McNutt wrote: >>> +void __led_init(led_id_t mask, int state) >>> +{ >>> +gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1); >> >> >> The direction register only exists when the PIO core hardware >> is configured in bidirectional mod

Re: [U-Boot] [PATCH] nios2: add gpio based status led driver

2010-04-20 Thread Thomas Chou
On 04/20/2010 09:19 PM, Scott McNutt wrote: >> +void __led_init(led_id_t mask, int state) >> +{ >> +gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1); > > > The direction register only exists when the PIO core hardware > is configured in bidirectional mode. > If the PIO core hardwa

Re: [U-Boot] [PATCH] nios2: add gpio based status led driver

2010-04-20 Thread Scott McNutt
Thomas, Thomas Chou wrote: > This patch adds a gpio based status led driver. The led mask > is used to specify the gpio pin. > > Signed-off-by: Thomas Chou > --- > board/altera/common/gpioled.c | 30 ++ > 1 files changed, 30 insertions(+), 0 deletions(-) > create