Re: [U-Boot] [PATCH] logbuff: Prevent an infinite loop for console output

2010-06-08 Thread Peter Tyser
Hi Wolfgang, > > I agree this fix isn't the best, but its better than the bug in my > > opinion. Ideally someone who uses the logbuff could provide a more > > elegant fix. Any takers? > > I don't want to replace one bug (that bites you) with another one ( > that bites somebody else). I think t

Re: [U-Boot] [PATCH] logbuff: Prevent an infinite loop for console output

2010-06-08 Thread Wolfgang Denk
Dear Peter Tyser, In message <1273253668.22784.57.ca...@localhost.localdomain> you wrote: > > > Hm. What if a board has "stdout" set to "lcd" or "nc" or any other > > device? Do we really want the text to be output on the serial console > > then? Doesn't this break the whole "stdout" concept? >

Re: [U-Boot] [PATCH] logbuff: Prevent an infinite loop for console output

2010-05-07 Thread Peter Tyser
On Fri, 2010-05-07 at 10:23 +0200, Detlev Zundel wrote: > Hi Peter, > > > When using 'logbuff' as stdout and the console loglevel is greater > > than a message's loglevel it is supposed to be both logged, and printed > > to the console. The logbuff_printk() function is responsible for both > > lo

Re: [U-Boot] [PATCH] logbuff: Prevent an infinite loop for console output

2010-05-07 Thread Detlev Zundel
Hi Peter, > When using 'logbuff' as stdout and the console loglevel is greater > than a message's loglevel it is supposed to be both logged, and printed > to the console. The logbuff_printk() function is responsible for both > logging and displaying the message. However, logbuff_printk() > previ