Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-08 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > > >> And the 1.2.6 has some fix for the deflate, so it > >> is maybe a good > >> base line for introducing it. > > > > Which exact fix are you referring to? > > I am referring to the zlib 1.2.5->1.2.6 changelog: > Added deflatePending() to return the amount

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-08 Thread Lei Wen
Hi Wolfgang, On Thu, Mar 8, 2012 at 4:13 PM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message > you > wrote: >> >> > I wonder which benefits we get for this price we are paying? >> >> The main reason I'd like to introduce this upgrade is for I want to >> add the compressing >> feature for u

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-08 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > > > I wonder which benefits we get for this price we are paying? > > The main reason I'd like to introduce this upgrade is for I want to > add the compressing > feature for uboot. This should be make optional code, including any extensions / additional fu

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-07 Thread Lei Wen
Hi Wolfgang, On Wed, Mar 7, 2012 at 10:30 PM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message > you > wrote: >> >> I miss add the zconf.h into the patch... >> V2 patch is attached... > > Argh.  Please NEVER send patches as attachments.  Always send them > inline.  See http://www.denx.de/wi

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-07 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > > I miss add the zconf.h into the patch... > V2 patch is attached... Argh. Please NEVER send patches as attachments. Always send them inline. See http://www.denx.de/wiki/U-Boot/Patches > As it copy from zlib home page, the improvement from 1.2.5 to 1.2.

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-07 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > --20cf300fafe1db2c6604ba8f33fe > Content-Type: text/plain; charset=ISO-8859-1 > > Hi, > > In this patch, I update the current zlib from 1.2.5 to 1.2.6. > > There is a lot of warnings when using checkpatch script, I don't know whether > I should fix it or

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-06 Thread Lei Wen
Hi Mike, On Wed, Mar 7, 2012 at 12:15 AM, Mike Frysinger wrote: > On Tuesday 06 March 2012 03:55:19 Lei Wen wrote: >> In this patch, I update the current zlib from 1.2.5 to 1.2.6. >> >> There is a lot of warnings when using checkpatch script, I don't know >> whether I should fix it or not... >> S

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 03:55:19 Lei Wen wrote: > In this patch, I update the current zlib from 1.2.5 to 1.2.6. > > There is a lot of warnings when using checkpatch script, I don't know > whether I should fix it or not... > Since it is just copy from as it is from upstream zlib 1.2.6, so I didn't