Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Stefano Babic
On 19/04/2013 10:27, Eric Bénard wrote: > Hi Stefano, > Hi Eric, >>> Can we please avoid such #ifdef's? Here, we could for example refer >>> to the board name (CONFIG_SYS_BOARD if you like the name, or some >>> custom defined CONFIG_BOARD_NAME like other boards do). >> >> And who does set CONF

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Eric Bénard
Hi Stefano, Le Fri, 19 Apr 2013 10:15:49 +0200, Stefano Babic a écrit : > On 18/04/2013 19:37, Wolfgang Denk wrote: > > Dear Pierre Aubert, > > > > In message <1366296086-22394-1-git-send-email-p.aub...@staubli.com> you > > wrote: > >> The SabreSD platform is available with i.MX6Q or i.MX6DL.

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Pierre AUBERT
Le 19/04/2013 10:15, Stefano Babic a écrit : int checkboard(void) { - puts("Board: MX6Q-SabreSD\n"); - +#ifdef CONFIG_MX6Q +puts("Board: MX6Q-SabreSD\n"); +#else +puts("Board: MX6DL-SabreSD\n"); +#endif Can we please avoid such #ifdef's? Here, we could for example refer to t

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Stefano Babic
On 18/04/2013 19:37, Wolfgang Denk wrote: > Dear Pierre Aubert, > > In message <1366296086-22394-1-git-send-email-p.aub...@staubli.com> you wrote: >> The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the >> support of the i.MX6DL. The config file and the board directory are

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-18 Thread Pierre AUBERT
Hello Wolfgang, Le 18/04/2013 19:37, Wolfgang Denk a écrit : Dear Pierre Aubert, In message <1366296086-22394-1-git-send-email-p.aub...@staubli.com> you wrote: The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the support of the i.MX6DL. The config file and the board di

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-18 Thread Pierre AUBERT
Hi Fabio, I can split the patch if you wish, but in this case the compilation would be broken for the sabreauto if only one of the two patches is applied. Best regards Pierre Aubert Le 18/04/2013 19:51, Fabio Estevam a écrit : Hi Pierre, On Thu, Apr 18, 2013 at 11:41 AM, Pierre Aubert wr

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-18 Thread Fabio Estevam
Hi Pierre, On Thu, Apr 18, 2013 at 11:41 AM, Pierre Aubert wrote: > diff --git a/boards.cfg b/boards.cfg > index f785da8..c002cf7 100644 > --- a/boards.cfg > +++ b/boards.cfg > @@ -256,9 +256,10 @@ mx53smd arm armv7 > mx53smd freesca > ima3-mx53

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-18 Thread Wolfgang Denk
Dear Pierre Aubert, In message <1366296086-22394-1-git-send-email-p.aub...@staubli.com> you wrote: > The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the > support of the i.MX6DL. The config file and the board directory are renamed > to remove the reference to the MX6Q. F