Re: [U-Boot] [PATCH] image: Fix Android boot image support

2014-10-21 Thread Ahmad Draidi
Hello, Mr. Glass On Tue, Oct 21, 2014 at 12:42 AM, Simon Glass wrote: > > Why have ANDR_BOOT_ARGS_SIZE? If you are going to malloc() anyway, you > may as well avoid the limit. Something like: > > char *bootargs = getenv("bootargs"); > int len = 0; > > if (*hdr->cmdline) >len += strlen(hdr->cm

Re: [U-Boot] [PATCH] image: Fix Android boot image support

2014-10-20 Thread Simon Glass
Hi Ahmad, On 17 October 2014 23:34, Ahmad Draidi wrote: > Hello Mr. Glass > > On Fri, Oct 17, 2014 at 11:19 PM, Simon Glass wrote: >> Hi, >> >> On 16 October 2014 22:52, Ahmad Draidi wrote: >>> This patch makes the following changes: >>> - Set kernel entry point correctly >>> - Append bootargs

Re: [U-Boot] [PATCH] image: Fix Android boot image support

2014-10-20 Thread Simon Glass
Hi, On 16 October 2014 22:52, Ahmad Draidi wrote: > This patch makes the following changes: > - Set kernel entry point correctly > - Append bootargs from image to global bootargs instead > of replacing them > - Return end address instead of size from android_image_get_end() > - Give corre

Re: [U-Boot] [PATCH] image: Fix Android boot image support

2014-10-17 Thread Ahmad Draidi
Hello Mr. Glass On Fri, Oct 17, 2014 at 11:19 PM, Simon Glass wrote: > Hi, > > On 16 October 2014 22:52, Ahmad Draidi wrote: >> This patch makes the following changes: >> - Set kernel entry point correctly >> - Append bootargs from image to global bootargs instead >> of replacing them >>

Re: [U-Boot] [PATCH] image: Fix Android boot image support

2014-10-17 Thread Simon Glass
Hi, On 16 October 2014 22:52, Ahmad Draidi wrote: > This patch makes the following changes: > - Set kernel entry point correctly > - Append bootargs from image to global bootargs instead > of replacing them > - Return end address instead of size from android_image_get_end() > - Give corre