Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

Hi Tom, On 22 April 2016 at 12:19, Tim Chick wrote: > > On 20/04/2016 15:40, Simon Glass wrote: >> Hi Tim, >> >> On 7 April 2016 at 11:20, Tim Chick wrote: >>> Sorry for top posting. Not in the office at the moment. >>> >>> Yes, I call debug_uart_init() before I have SDRAM, in lowlevel_init(). I

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

On 20/04/2016 15:40, Simon Glass wrote: > Hi Tim, > > On 7 April 2016 at 11:20, Tim Chick wrote: >> Sorry for top posting. Not in the office at the moment. >> >> Yes, I call debug_uart_init() before I have SDRAM, in lowlevel_init(). I >> need the debug uart to help me debug lowlevel_init! >>> The

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

gt; > -Original Message- > From: Daniel Schwierzeck [mailto:daniel.schwierz...@gmail.com] > Sent: 07 April 2016 17:48 > To: Tim Chick > Cc: yamada.masah...@socionext.com; u-boot@lists.denx.de; Simon Glass > ; Stefan Roese > Subject: Re: [U-Boot] [PATCH] debug_uart: output CR al

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

April 2016 17:48 To: Tim Chick Cc: yamada.masah...@socionext.com; u-boot@lists.denx.de; Simon Glass ; Stefan Roese Subject: Re: [U-Boot] [PATCH] debug_uart: output CR along with LF Hi Tim, 2016-04-04 17:16 GMT+02:00 Tim Chick : > Hi Masahiro, > > This patch breaks the debug_uart o

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

Please see below: > > > Hi Tim, > > 2016-04-05 0:16 GMT+09:00 Tim Chick : >> Hi Masahiro, >> >> This patch breaks the debug_uart on my MIPS board. It means printascii now >> uses the stack, and my board does not have a stack when debug_uart_init is >> called. debug_uart_init calls printascii

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

Hi Tim, 2016-04-04 17:16 GMT+02:00 Tim Chick : > Hi Masahiro, > > This patch breaks the debug_uart on my MIPS board. It means printascii now > uses the stack, and my board does not have a stack when debug_uart_init is > called. debug_uart_init calls printascii if DEBUG_UART_ANNOUNCE is defined.

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

Hi Tim, 2016-04-05 0:16 GMT+09:00 Tim Chick : > Hi Masahiro, > > This patch breaks the debug_uart on my MIPS board. It means printascii now > uses the stack, and my board does not have a stack when debug_uart_init is > called. debug_uart_init calls printascii if DEBUG_UART_ANNOUNCE is defined. >

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

Hi Masahiro, This patch breaks the debug_uart on my MIPS board. It means printascii now uses the stack, and my board does not have a stack when debug_uart_init is called. debug_uart_init calls printascii if DEBUG_UART_ANNOUNCE is defined. The patch below fixes it, and keeps your change: Thanks

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

On 8 March 2016 at 16:33, Simon Glass wrote: > On 8 March 2016 at 02:19, Masahiro Yamada > wrote: >> >> The serial output from the debug UART carries on going far to the >> right in the console. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> include/debug_uart.h | 4 +++- >> 1 file changed,

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

On 8 March 2016 at 02:19, Masahiro Yamada wrote: > > The serial output from the debug UART carries on going far to the > right in the console. > > Signed-off-by: Masahiro Yamada > --- > > include/debug_uart.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH] debug_uart: output CR along with LF

On 08.03.2016 10:19, Masahiro Yamada wrote: The serial output from the debug UART carries on going far to the right in the console. Signed-off-by: Masahiro Yamada Yes, this has bugged me as well a few times as well. Thanks! Reviewed-by: Stefan Roese Thanks, Stefan