Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-03-29 Thread Anatolij Gustschin
Hello Wolfgang, On Sat, 5 Jan 2013 20:45:48 +0100 Wolfgang Denk wrote: > lcd_color_fg and lcd_color_bg had to be declared in board specific > code, but were not actually used there; in addition, we have getter / > setter functions for these, which were not used either. > > Get rid of the globa

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-25 Thread Jeroen Hofstee
On 01/05/2013 08:45 PM, Wolfgang Denk wrote: lcd_color_fg and lcd_color_bg had to be declared in board specific code, but were not actually used there; in addition, we have getter / setter functions for these, which were not used either. Get rid of the global variables, and use the getter functi

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-12 Thread Simon Glass
Hi Jeroen, On Sun, Jan 6, 2013 at 2:43 PM, Jeroen Hofstee wrote: > On 01/05/2013 08:50 PM, Wolfgang Denk wrote: >> >> Dear Anatolij, >> >> In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: >>> >>> lcd_color_fg and lcd_color_bg had to be declared in board specific >>> code, but w

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-12 Thread Simon Glass
On Sat, Jan 5, 2013 at 11:45 AM, Wolfgang Denk wrote: > lcd_color_fg and lcd_color_bg had to be declared in board specific > code, but were not actually used there; in addition, we have getter / > setter functions for these, which were not used either. > > Get rid of the global variables, and use

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-06 Thread Anatolij Gustschin
Hello Wolfgang, On Sat, 05 Jan 2013 20:50:01 +0100 Wolfgang Denk wrote: > Dear Anatolij, > > In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: > > lcd_color_fg and lcd_color_bg had to be declared in board specific > > code, but were not actually used there; in addition, we hav

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-06 Thread Jeroen Hofstee
On 01/05/2013 08:50 PM, Wolfgang Denk wrote: Dear Anatolij, In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: lcd_color_fg and lcd_color_bg had to be declared in board specific code, but were not actually used there; in addition, we have getter / setter functions for these, wh

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-05 Thread Wolfgang Denk
Dear Anatolij, In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: > lcd_color_fg and lcd_color_bg had to be declared in board specific > code, but were not actually used there; in addition, we have getter / > setter functions for these, which were not used either. > > Get rid of