Re: [U-Boot] [PATCH] TCP and wget implementation. Ptch V5 1 of 3

2018-01-29 Thread Heinrich Schuchardt
On 01/29/2018 06:30 PM, Duncan Hare wrote: >> The patch is trying to put everything into net.c. This is a mess and >> not where we should head to. > > Not at all. I tried that and it was correctly rejected. The TCP > functions are in tcp.c, and the wget functions in wget.c > > There is no socket

Re: [U-Boot] [PATCH] TCP and wget implementation. Ptch V5 1 of 3

2018-01-29 Thread Duncan Hare
> The patch is trying to put everything into net.c. This is a mess and > not where we should head to. Not at all. I tried that and it was correctly rejected. The TCP functions are in tcp.c, and the wget functions in wget.c There is no socket. There is no socket analogue. There is no widespread c

Re: [U-Boot] [PATCH] TCP and wget implementation. Patch V5, 3 of 3.

2018-01-28 Thread Calvin Johnson
Hi Duncan Hare, > -Original Message- > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of > d...@synoia.com > Sent: Monday, January 29, 2018 9:24 AM > To: duncanch...@yahoo.com > Cc: u-boot@lists.denx.de; Joe Hershberger ; > Maxime Ripard ; Jagan Teki > > Subject: [U-Boot] [P

Re: [U-Boot] [PATCH] TCP and wget implementation. Ptch V5 1 of 3

2018-01-28 Thread Heinrich Schuchardt
On 01/29/2018 02:34 AM, Duncan Hare wrote: > Date: Sun, 28 Jan 2018 11:25:51 -0800 > > This is the interface and Kconfig files for introducing TCP and wget > into u-boot. > > Interfaces are in net.c and net.h, ping is modified to the new ip send > interface, and UDP and TCP have shim procedures

Re: [U-Boot] [PATCH] TCP and wget implementation v5.1

2018-01-16 Thread Joe Hershberger
Hi Duncan, On Mon, Jan 15, 2018 at 11:01 AM, Duncan Hare wrote: > > > > > Hi Duncan, > > On Wed, Jan 10, 2018 at 8:18 PM, Duncan Hare wrote: >> Date: Wed, 10 Jan 2018 17:54:07 -0800 >> Subject: [PATCH] git_msg_1 >> >> TCP and wget implementation. > > Sounds like

Re: [U-Boot] [PATCH] TCP and wget implementation v5.1

2018-01-15 Thread Duncan Hare
Hi Duncan, On Wed, Jan 10, 2018 at 8:18 PM, Duncan Hare wrote: > Date: Wed, 10 Jan 2018 17:54:07 -0800 > Subject: [PATCH] git_msg_1 > > TCP and wget implementation. Sounds like this should be the title of the series cover letter. I thought we agreed that this should be sent as a series. That

Re: [U-Boot] [PATCH] TCP and wget implementation v5.1

2018-01-12 Thread Joe Hershberger
Hi Duncan, On Wed, Jan 10, 2018 at 8:18 PM, Duncan Hare wrote: > Date: Wed, 10 Jan 2018 17:54:07 -0800 > Subject: [PATCH] git_msg_1 > > TCP and wget implementation. Sounds like this should be the title of the series cover letter. I thought we agreed that this should be sent as a series. That mea

Re: [U-Boot] [PATCH] TCP and wget implementation v4

2018-01-05 Thread Joe Hershberger
On Fri, Jan 5, 2018 at 4:10 PM, Duncan Hare wrote: >> > >> > A note on this TCP implementation. In TCP the transmitting TCP >> > guarantees delivery of a stream, and the receiving TCP guarantees >> > ordered of delivery of the stream. In this implementation The >> > kernel memory buffer and the TC

Re: [U-Boot] [PATCH] TCP and wget implementation v4

2018-01-05 Thread Duncan Hare
> > > > A note on this TCP implementation. In TCP the transmitting TCP > > guarantees delivery of a stream, and the receiving TCP guarantees > > ordered of delivery of the stream. In this implementation The > > kernel memory buffer and the TCP sequence number is used to order > > the stream. for th

Re: [U-Boot] [PATCH] TCP and wget implementation v4

2018-01-05 Thread Joe Hershberger
On Wed, Jan 3, 2018 at 5:01 PM, Duncan Hare wrote: >> >>>selects the LIB_RAND feature since it is required. >> > >> > Thanks: will be in u-boot/cmd/Kconfig >> > >> >>Are we lookin at a series of patches, or a concurrent set? >> > >> > At this time a series of three, but I'd take advice on the pref

Re: [U-Boot] [PATCH] TCP and wget implementation v4

2018-01-03 Thread Duncan Hare
> >>>selects the LIB_RAND feature since it is required. > > > > Thanks: will be in u-boot/cmd/Kconfig > > > >>Are we lookin at a series of patches, or a concurrent set? > > > > At this time a series of three, but I'd take advice on the preferred > > procedure. > > Remember that the goal is

Re: [U-Boot] [PATCH] TCP and wget implementation v3

2018-01-03 Thread Joe Hershberger
On Wed, Jan 3, 2018 at 3:07 PM, Duncan Hare wrote: > >>>selects the LIB_RAND feature since it is required. > > Thanks: will be in u-boot/cmd/Kconfig > >>Are we lookin at a series of patches, or a concurrent set? > > At this time a series of three, but I'd take advice on the preferred > procedure.

Re: [U-Boot] [PATCH] TCP and wget implementation v3

2018-01-03 Thread Duncan Hare
>>selects the LIB_RAND feature since it is required. Thanks: will be in u-boot/cmd/Kconfig >Are we lookin at a series of patches, or a concurrent set? At this time a series of three, but I'd take advice on the preferred procedure. (1) cmd/Kconfig cmd/net.c net/Kconfig net/net.c net/ping.c

Re: [U-Boot] [PATCH] TCP and wget implementation v3

2018-01-03 Thread Joe Hershberger
On Tue, Dec 19, 2017 at 11:02 AM, Duncan Hare wrote: >>I'd like to see the shim and all changes to existing stack as a >>separate patch to make review simpler. > > In this patch. > >>Also please make TCP and wget into 2 other separate patches. > > Yes, following. > >> Yes it should... you could ha

Re: [U-Boot] [PATCH] TCP and wget implementation.

2017-12-05 Thread Joe Hershberger
Hi Duncan, The subject should not end with a '.' character. Also, this should have been marked as v2. Please mark the next as v3. On Wed, Nov 8, 2017 at 6:34 PM, Duncan Hare wrote: > his is the interface and Kconfig files for introducing TCP and wget > into u-boot. Missing 'T' at the beginning