Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-04-30 Thread Stefano Babic
Hi Terry, >[Ty]: env_ptr is defined in env_mmc.c and the value is > assigned in env_common.c. Correct me if I'm wrong. No, you are right - env_relocate() called malloc and initialize the pointer. Best regards, Stefano -- = DE

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-04-29 Thread Lv Terry-R65388
] [PATCH] Save environment data to mmc. Terry Lv wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. Hi Terry, > > Signed-off-by: Terry Lv > --- > arch/arm/lib/board.c | 10 ++-- > arch/powerpc/lib/board.c | 12 ++

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-04-29 Thread Stefano Babic
Terry Lv wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. Hi Terry, > > Signed-off-by: Terry Lv > --- > arch/arm/lib/board.c | 10 ++-- > arch/powerpc/lib/board.c | 12 ++-- > common/Makefile |1 + > common/cmd_nvedi

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-04-28 Thread Andy Fleming
On Wed, Apr 28, 2010 at 2:52 AM, Terry Lv wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. > > Signed-off-by: Terry Lv > diff --git a/common/env_mmc.c b/common/env_mmc.c > new file mode 100644 > index 000..202370e > --- /dev/null > ++

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-03-03 Thread Liu Hui-R64343
Hi, Terry, > -Original Message- > From: u-boot-boun...@lists.denx.de > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Lv Terry-R65388 > Sent: 2010年3月4日 11:01 > To: Stefano Babic > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] Save environment data

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-03-03 Thread Lv Terry-R65388
r the initalization for ARM and PPC, It will be added for all architectures. Thanks a lot ~~ Yours Terry -Original Message- From: Stefano Babic [mailto:sba...@denx.de] Sent: 2010年3月3日 1:03 To: Lv Terry-R65388 Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Save environment da

Re: [U-Boot] [PATCH] Save environment data to mmc.

2010-03-02 Thread Stefano Babic
Terry Lv wrote: > diff --git a/common/env_mmc.c b/common/env_mmc.c > +#include > +#include > +#include > + > +#if defined(CONFIG_CMD_ENV) && defined(CONFIG_CMD_MMC) This seems not correct. If not explicitely set, we get a compiler error. Assuming you has taken this check from env_nand.c, this

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-05 Thread Lv Terry-R65388
It works well in our project. So I want to add it to u-boot mainline. Thanks~~ Yours Terry -Original Message- From: Mike Frysinger [mailto:vap...@gentoo.org] Sent: 2009年11月5日 20:10 To: u-boot@lists.denx.de Cc: Lv Terry-R65388 Subject: Re: [U-Boot] [PATCH] Save environment da

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-05 Thread Wolfgang Denk
Dear Terry Lv, In message <12574070132761-git-send-email-r65...@freescale.com> you wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. ... > + if (!crc1_ok && !crc2_ok) > + gd->env_valid = 0; > + else if (crc1_ok && !crc2_ok

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-04 Thread Mike Frysinger
On Wednesday 04 November 2009 05:02:44 Terry Lv wrote: > This patch is to save environment data to mmc card. > It uses interfaces defined in generic mmc. > > Signed-off-by: Terry Lv > --- > common/cmd_nvedit.c |3 +- > common/env_mmc.c > include/environment.h | > lib_arm/board.c |

Re: [U-Boot] [PATCH] Save environment data to mmc.

2009-11-04 Thread Lv Terry-R65388
Sorry, this patch has something wrong. I'll send out a new one for review. Yours Terry -Original Message- From: Lv Terry-R65388 Sent: 2009年11月4日 17:52 To: u-boot@lists.denx.de Cc: Lv Terry-R65388 Subject: [PATCH] Save environment data to mmc. This patch is to save environment d