Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-20 Thread Scott Wood
On 12/20/2012 09:05:49 AM, Chris Kiick wrote: Hi, Well, you are of course 100% correct. I went back and took out the nand plat stuff, made my own driver and used NAND_ECC_HW mode. A few tweaks and it works just great. No changes needed to nand base code. The mode names are a bit mislea

Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-20 Thread Chris Kiick
2 3:40:49 PM > Subject: Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat >driver > > On 12/19/2012 03:16:19 PM, Chris Kiick wrote: > > Hi, > > Thanks for the reply. This is my first patch to u-boot. Any advice is > > appreciated. Comments in-line be

Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-20 Thread Chris Kiick
CH] NAND: allow custom SW ECC when using nand plat >driver > > On 12/18/2012 05:27:00 PM, Chris Kiick wrote: > > Allow boards to set their own ECC layouts and functions in NAND_PLAT_INIT > > without being stomped on by nand_base.c intialization. > > > > Sign

Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-19 Thread Scott Wood
On 12/19/2012 03:40:03 PM, Scott Wood wrote: I seem to see other nand drivers setting up ecc layouts and then calling nand_scan_tail(), I'm not sure how they are getting around this. They don't use NAND_ECC_SOFT. Wait, just layout, not algorithm? How is that a problem with either NAND

Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-19 Thread Scott Wood
9, 2012 1:02:52 PM > Subject: Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat >driver > > On 12/18/2012 05:27:00 PM, Chris Kiick wrote: > > Allow boards to set their own ECC layouts and functions in NAND_PLAT_INIT > > without being stom

Re: [U-Boot] [PATCH] NAND: allow custom SW ECC when using nand plat driver

2012-12-19 Thread Scott Wood
On 12/18/2012 05:27:00 PM, Chris Kiick wrote: Allow boards to set their own ECC layouts and functions in NAND_PLAT_INIT without being stomped on by nand_base.c intialization. Signed-off-by: ckiick --- drivers/mtd/nand/nand_base.c | 11 +++ drivers/mtd/nand/nand_plat.c |4 ++--