Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-13 Thread Detlev Zundel
Hi, > On Wed 12 Aug 2009 15:48, Scott Wood pondered: >> On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: >> > Hi Timur, >> > >> > >> +#ifdef CONFIG_TFTP_QUIET >> > >> +#define puts_quiet(fmt) >> > >> +#else >> > >> +#define puts_quiet(fmt)                puts(fmt); >> > >> +#endif >

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-12 Thread Mike Frysinger
On Monday 10 August 2009 16:26:20 Robin Getz wrote: > From bca49fb5e3045bc175e924999a4015804c39c5c6 Mon Sep 17 00:00:00 2001 > From: Robin Getz > > I was using this when I was looking at some other recent tftp performance, > and thought I would share. I really don't think it belongs, as it is > (a

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-12 Thread Robin Getz
On Wed 12 Aug 2009 15:48, Scott Wood pondered: > On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: > > Hi Timur, > > > > >> +#ifdef CONFIG_TFTP_QUIET > > >> +#define puts_quiet(fmt) > > >> +#else > > >> +#define puts_quiet(fmt)                puts(fmt); > > >> +#endif > > > > > > This

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-12 Thread Scott Wood
On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: > Hi Timur, > > >> +#ifdef CONFIG_TFTP_QUIET > >> +#define puts_quiet(fmt) > >> +#else > >> +#define puts_quiet(fmt)                puts(fmt); > >> +#endif > > > > This looks backwards to me. I would do this: > > > > #ifdef CONFIG_TFT

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-12 Thread Detlev Zundel
Hi Timur, >> +#ifdef CONFIG_TFTP_QUIET >> +#define puts_quiet(fmt) >> +#else >> +#define puts_quiet(fmt)                puts(fmt); >> +#endif > > This looks backwards to me. I would do this: > > #ifdef CONFIG_TFTP_QUIET > #define puts(x) puts_quiet(x) > #endif > > That way, you don't need to chan

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Robin Getz
On Mon 10 Aug 2009 16:55, Timur Tabi pondered: > On Mon, Aug 10, 2009 at 3:26 PM, Robin Getz wrote: > > --- a/net/tftp.c > > +++ b/net/tftp.c > > @@ -22,6 +22,16 @@ > >                                        /* (for checking the image size)     > >    */ > >  #define HASHES_PER_LINE        65    

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Scott Wood
On Mon, Aug 10, 2009 at 03:55:20PM -0500, Timur Tabi wrote: > > +#ifdef CONFIG_TFTP_QUIET > > +#define puts_quiet(fmt) > > +#else > > +#define puts_quiet(fmt)                puts(fmt); > > +#endif > > This looks backwards to me. I would do this: > > #ifdef CONFIG_TFTP_QUIET > #define puts(x) put

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Timur Tabi
On Mon, Aug 10, 2009 at 3:26 PM, Robin Getz wrote: > From bca49fb5e3045bc175e924999a4015804c39c5c6 Mon Sep 17 00:00:00 2001 > From: Robin Getz > > I was using this when I was looking at some other recent tftp performance, > and thought I would share. I really don't think it belongs, as it is > (a)