Re: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/16/12 05:59, Pavel Herrmann wrote: > On Sunday 16 September 2012 14:37:16 Marek Vasut wrote: >> Dear Pavel Herrmann, ... Won't include/sata.h work just fine ? > > I feel include/sata.h is a "consumer-facing" header, and > implementation details

Re: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

Dear Pavel Herrmann, > On Sunday 16 September 2012 14:37:16 Marek Vasut wrote: > > Dear Pavel Herrmann, > > > > ... > > > > Won't include/sata.h work just fine ? > > I feel include/sata.h is a "consumer-facing" header, and implementation > details such as the array used for all data-retention

Re: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

On Sunday 16 September 2012 14:37:16 Marek Vasut wrote: > Dear Pavel Herrmann, > ... > Won't include/sata.h work just fine ? I feel include/sata.h is a "consumer-facing" header, and implementation details such as the array used for all data-retention for command and drivers should not be there.

Re: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

Dear Pavel Herrmann, > Move all extern declarations of sata_dev_desc into a single header file. > > Signed-off-by: Pavel Herrmann > --- > drivers/block/ata_piix.c | 4 +--- > drivers/block/dwc_ahsata.c | 1 + > drivers/block/dwc_ahsata.h | 2 -- > drivers/block/fsl_sata.c | 3 +-