Re: [U-Boot] [PATCH] Add suport for the graphic controller included in the JADE SOC

Anatolij Gustschin wrote: >> But a common include file with the register offsets seems to be a >> good idea to me. > > I'will prepare a list of register offset defines for "include/mb862xx.h" > and send a patch so that you can use them in your code. now the patch is out: http://lists.denx.de/pipe

Re: [U-Boot] [PATCH] Add suport for the graphic controller included in the JADE SOC

Dear Anatolij & Matthias, in message <4a4c7d73.1080...@denx.de> you wrote: > > >>> + if(0 == bpp){ > >> if (bpp == 0) { > > > > The spaces are OK but why turn around the comparison? I always use Because "0 == bpp" is ugly. > > this style to prevent from unwanted assignments. Well, GCC

Re: [U-Boot] [PATCH] Add suport for the graphic controller included in the JADE SOC

Matthias Weisser wrote: Anatolij Gustschin schrieb am 01.07.2009 um 15:40: >> Dear Matthias, >> >> Thanks for this patch! Please see some comments/issues below which > we >> should resolve before committing the driver. > > First of all thanks for your detailed comments. I fix them all before

Re: [U-Boot] [PATCH] Add suport for the graphic controller included in the JADE SOC

Dear Matthias, Thanks for this patch! Please see some comments/issues below which we should resolve before committing the driver. Matthias Weisser wrote: > Signed-off-by: Matthias Weisser > --- > drivers/video/jadegdc.c | 205 > +++ > 1 files change