Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-04-18 Thread Scott Wood
On 04/03/2013 09:02:15 AM, Jim Chargin wrote: I apologize for being so late with this question. York Sun freescale.com> writes: > > When we need the copied code/data in the main memory, we can flush the > cache now. It uses the existing function flush_cache. Syntax is > > flush_cache > >

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-04-03 Thread Jim Chargin
I apologize for being so late with this question. York Sun freescale.com> writes: > > When we need the copied code/data in the main memory, we can flush the > cache now. It uses the existing function flush_cache. Syntax is > > flush_cache > > The addr and size are given in hexadecimal. Like

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Wolfgang Denk
Dear Tom, In message <514c6ab0.7090...@ti.com> you wrote: > > > > I also wonder about this. To me it appears much easier to use a > > IH_TYPE_STANDALONE image, which 1) provides the needed size > > information and 2) can be used with bootm, so the required > > additional steps (flush caches, r

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2013 12:48 PM, Scott Wood wrote: > On 03/22/2013 09:29:04 AM, Tom Rini wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 03/22/2013 10:03 AM, Wolfgang Denk wrote: >>> Dear Tom, >>> >>> In message <514c4be8.10...@ti.com> you wr

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Scott Wood
On 03/22/2013 09:29:04 AM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2013 10:03 AM, Wolfgang Denk wrote: > Dear Tom, > > In message <514c4be8.10...@ti.com> you wrote: >> >> It seems like we're going around and around with one point not >> being addressed. When using

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Scott Wood
On 03/20/2013 09:51:03 AM, Wolfgang Denk wrote: Dear York Sun, In message <1363724992-9803-1-git-send-email-york...@freescale.com> you wrote: > When we need the copied code/data in the main memory, we can flush the > cache now. It uses the existing function flush_cache. Syntax is > > flush_

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Albert ARIBAUD
Hi Tom, On Fri, 22 Mar 2013 10:29:04 -0400, Tom Rini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/22/2013 10:03 AM, Wolfgang Denk wrote: > > Dear Tom, > > > > In message <514c4be8.10...@ti.com> you wrote: > >> > >> It seems like we're going around and around with one poi

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2013 10:03 AM, Wolfgang Denk wrote: > Dear Tom, > > In message <514c4be8.10...@ti.com> you wrote: >> >> It seems like we're going around and around with one point not >> being addressed. When using 'go', how do you know the size to >> flu

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Wolfgang Denk
Dear Tom, In message <514c4be8.10...@ti.com> you wrote: > > It seems like we're going around and around with one point not being > addressed. When using 'go', how do you know the size to flush? And > since Scott is talking about performance testing apps, the cache > should not be disabled (unles

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-22 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2013 02:30 AM, Albert ARIBAUD wrote: > Hi Scott, > >> Perhaps it could be, or the application could be altered to >> release secondary cores through the spin table. I don't think >> that excuses a situation where some ways of putting a blo

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Albert ARIBAUD
Hi Scott, > Perhaps it could be, or the application could be altered to release > secondary cores through the spin table. I don't think that excuses a > situation where some ways of putting a blob of bytes into RAM flush the > cache (to the extent the architecture requires it for the blob o

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Scott Wood
On 03/21/2013 02:25:10 PM, Wolfgang Denk wrote: Dear Scott, In message <1363890157.31522.14@snotra> you wrote: > > As above it's from flash (I assume NOR) to RAM. The "why" is to be =20 > able to run the code from RAM. :-P * Why don't you run it form flash? Presumably because it's slow.

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Wolfgang Denk
Dear Scott, In message <1363890157.31522.14@snotra> you wrote: > > As above it's from flash (I assume NOR) to RAM. The "why" is to be =20 > able to run the code from RAM. :-P * Why don't you run it form flash? * Why do you insist on using the "go" command (instead of "bootm" with a IH_TYPE_ST

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Wolfgang Denk
Dear Scott Wood, In message <1363889275.31522.12@snotra> you wrote: > > > There is no need to change any syntax. > > Then how would we know what range to flush? Use a IH_TYPE_STANDALONE U-Boot image, and bootm? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang D

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Scott Wood
On 03/21/2013 12:02:23 AM, Sricharan R wrote: On Thursday 21 March 2013 06:01 AM, Scott Wood wrote: > On 03/20/2013 07:27:29 PM, Michael Cashwell wrote: >> On Mar 20, 2013, at 7:48 PM, Scott Wood wrote: >> >> > On 03/20/2013 06:33:41 PM, Michael Cashwell wrote: >> > >> >> What is the purpose

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Scott Wood
On 03/21/2013 08:37:32 AM, Wolfgang Denk wrote: Dear Tom, In message <20130321122923.GB26945@bill-the-cat> you wrote: > > > Not really. Only a tiny fraction of users will ever run any standalone > > applications, so please let's save the memory footprint for the > > overwhelming majority of u

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Scott Wood
On 03/21/2013 12:58:37 PM, Albert ARIBAUD wrote: Hi Scott, On Wed, 20 Mar 2013 17:35:51 -0500, Scott Wood wrote: > On 03/20/2013 05:11:57 PM, Albert ARIBAUD wrote: > > Hi Scott, > > > > On Wed, 20 Mar 2013 14:36:05 -0500, Scott Wood > > wrote: > > > > > On 03/20/2013 02:15:19 PM, Tom Rini wro

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Albert ARIBAUD
Hi Scott, On Wed, 20 Mar 2013 17:35:51 -0500, Scott Wood wrote: > On 03/20/2013 05:11:57 PM, Albert ARIBAUD wrote: > > Hi Scott, > > > > On Wed, 20 Mar 2013 14:36:05 -0500, Scott Wood > > wrote: > > > > > On 03/20/2013 02:15:19 PM, Tom Rini wrote: > > > > On Wed, Mar 20, 2013 at 11:43:15AM -0

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Wolfgang Denk
Dear Tom, In message <20130321122923.GB26945@bill-the-cat> you wrote: > > > Not really. Only a tiny fraction of users will ever run any standalone > > applications, so please let's save the memory footprint for the > > overwhelming majority of users who do not need that. > > Well, can we run int

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-21 Thread Tom Rini
On Thu, Mar 21, 2013 at 06:39:31AM +0100, Wolfgang Denk wrote: > Dear Tom Rini, > > In message <20130320195919.GR25919@bill-the-cat> you wrote: > > > > OK, so this does sound like a real need / use for it, and if we added > > the granularity of CONFIG_CMD_CACHE_FLUSH or similar, it would be > > r

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Wolfgang Denk
Dear Scott Wood, In message <1363815061.25034.18@snotra> you wrote: > > > Hadn't seen that command before, where is it? > > common/cmd_mp.c This depends on CONFIG_MP, which is undocumented. Can you please add / have added documentation for this config option? Thanks. Best regards, Wolfgang

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Wolfgang Denk
Dear Tom Rini, In message <20130320195919.GR25919@bill-the-cat> you wrote: > > OK, so this does sound like a real need / use for it, and if we added > the granularity of CONFIG_CMD_CACHE_FLUSH or similar, it would be > reasonable to turn it on to a large number of boards for a small space > savin

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Sricharan R
On Thursday 21 March 2013 06:01 AM, Scott Wood wrote: > On 03/20/2013 07:27:29 PM, Michael Cashwell wrote: >> On Mar 20, 2013, at 7:48 PM, Scott Wood wrote: >> >> > On 03/20/2013 06:33:41 PM, Michael Cashwell wrote: >> > >> >> What is the purpose of limiting the memory range to be flushed? Is ther

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 07:27:29 PM, Michael Cashwell wrote: On Mar 20, 2013, at 7:48 PM, Scott Wood wrote: > On 03/20/2013 06:33:41 PM, Michael Cashwell wrote: > >> What is the purpose of limiting the memory range to be flushed? Is there a reason one might want to NOT flush certain data sitting in a

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Michael Cashwell
On Mar 20, 2013, at 7:48 PM, Scott Wood wrote: > On 03/20/2013 06:33:41 PM, Michael Cashwell wrote: > >> What is the purpose of limiting the memory range to be flushed? Is there a >> reason one might want to NOT flush certain data sitting in a dirty cache >> line out to memory before doing a g

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 06:33:41 PM, Michael Cashwell wrote: On Mar 20, 2013, at 6:35 PM, Scott Wood wrote: > Really, instead of adding one command, you want to modify *two* commands to do the same thing separately, which involves changing the syntax of both commands to accept memory range informat

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Michael Cashwell
On Mar 20, 2013, at 6:35 PM, Scott Wood wrote: > Really, instead of adding one command, you want to modify *two* commands to > do the same thing separately, which involves changing the syntax of both > commands to accept memory range information? What is the purpose of limiting the memory rang

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 05:11:57 PM, Albert ARIBAUD wrote: Hi Scott, On Wed, 20 Mar 2013 14:36:05 -0500, Scott Wood wrote: > On 03/20/2013 02:15:19 PM, Tom Rini wrote: > > On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > > > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > > > >Dear Albert

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Albert ARIBAUD
Hi Scott, On Wed, 20 Mar 2013 14:36:05 -0500, Scott Wood wrote: > On 03/20/2013 02:15:19 PM, Tom Rini wrote: > > On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > > > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > > > >Dear Albert, > > > > > > > >In message <20130320145927.2031b91

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 02:59:19 PM, Tom Rini wrote: On Wed, Mar 20, 2013 at 02:36:05PM -0500, Scott Wood wrote: > On 03/20/2013 02:15:19 PM, Tom Rini wrote: > >On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > >> On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > >> >Dear Albert, > >> > > >> >I

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Tom Rini
On Wed, Mar 20, 2013 at 02:36:05PM -0500, Scott Wood wrote: > On 03/20/2013 02:15:19 PM, Tom Rini wrote: > >On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > >> On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > >> >Dear Albert, > >> > > >> >In message <20130320145927.2031b913@lilith> yo

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread York Sun
On 03/20/2013 12:15 PM, Tom Rini wrote: > On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: >> On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: >>> Dear Albert, >>> >>> In message <20130320145927.2031b913@lilith> you wrote: I do understand what it does, but I still don't get why

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 02:15:19 PM, Tom Rini wrote: On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > >Dear Albert, > > > >In message <20130320145927.2031b913@lilith> you wrote: > >> > >> I do understand what it does, but I still don't get why

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Tom Rini
On Wed, Mar 20, 2013 at 11:43:15AM -0500, Scott Wood wrote: > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > >Dear Albert, > > > >In message <20130320145927.2031b913@lilith> you wrote: > >> > >> I do understand what it does, but I still don't get why it should be > >> done, since precisely paylo

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 12:38:13 PM, Albert ARIBAUD wrote: Hi Scott, On Wed, 20 Mar 2013 11:43:15 -0500, Scott Wood wrote: > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > > Dear Albert, > > > > In message <20130320145927.2031b913@lilith> you wrote: > > > > > > I do understand what it does, but I sti

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Albert ARIBAUD
Hi Scott, On Wed, 20 Mar 2013 11:43:15 -0500, Scott Wood wrote: > On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: > > Dear Albert, > > > > In message <20130320145927.2031b913@lilith> you wrote: > > > > > > I do understand what it does, but I still don't get why it should be > > > done, since pr

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Scott Wood
On 03/20/2013 09:58:36 AM, Wolfgang Denk wrote: Dear Albert, In message <20130320145927.2031b913@lilith> you wrote: > > I do understand what it does, but I still don't get why it should be > done, since precisely payload control transfer happens through bootm and > the like which already prop

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Wolfgang Denk
Dear Albert, In message <20130320145927.2031b913@lilith> you wrote: > > I do understand what it does, but I still don't get why it should be > done, since precisely payload control transfer happens through bootm and > the like which already properly flush cache. Full agrement. > Is there an ARM

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Wolfgang Denk
Dear York Sun, In message <1363724992-9803-1-git-send-email-york...@freescale.com> you wrote: > When we need the copied code/data in the main memory, we can flush the > cache now. It uses the existing function flush_cache. Syntax is > > flush_cache > > The addr and size are given in hexadecima

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-20 Thread Albert ARIBAUD
Hi Scott, On Tue, 19 Mar 2013 18:32:39 -0500, Scott Wood wrote: > On 03/19/2013 05:07:33 PM, York Sun wrote: > > On 03/19/2013 03:01 PM, Albert ARIBAUD wrote: > > > What's the point of this command exactly? I can see the point of > > range > > > flushes (and invalidates) in the code for driver

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-19 Thread Scott Wood
On 03/19/2013 05:07:33 PM, York Sun wrote: On 03/19/2013 03:01 PM, Albert ARIBAUD wrote: > What's the point of this command exactly? I can see the point of range > flushes (and invalidates) in the code for drivers that use DMA, but as a > shell command, I fail to see the interest of it. > I

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-19 Thread York Sun
On 03/19/2013 03:01 PM, Albert ARIBAUD wrote: > What's the point of this command exactly? I can see the point of range > flushes (and invalidates) in the code for drivers that use DMA, but as a > shell command, I fail to see the interest of it. > I am actually expecting this question. We have a s

Re: [U-Boot] [RFC] command/cache: Add flush_cache command

2013-03-19 Thread Albert ARIBAUD
Hi York, On Tue, 19 Mar 2013 13:29:52 -0700, York Sun wrote: > When we need the copied code/data in the main memory, we can flush the > cache now. It uses the existing function flush_cache. Syntax is > > flush_cache > > The addr and size are given in hexadecimal. Like memory command, there i