Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

Hi Kever, On Fri, 21 Jun 2024 at 21:49, Kever Yang wrote: > > Hi Simon, > > On 2024/6/21 22:57, Simon Glass wrote: > > Hi Jonas, > > > > On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: > >> Hi Simon, > >> > >> On 2024-06-21 01:06, Simon Glass wrote: > >>> The code here is confusing due to lar

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

Hi Simon, On 2024/6/21 22:57, Simon Glass wrote: Hi Jonas, On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether SDRA

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

Hi Jonas, On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: > > Hi Simon, > > On 2024-06-21 01:06, Simon Glass wrote: > > The code here is confusing due to large blocks which are #ifdefed out. > > Add a function phase_sdram_init() which returns whether SDRAM init > > should happen in the current

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: > The code here is confusing due to large blocks which are #ifdefed out. > Add a function phase_sdram_init() which returns whether SDRAM init > should happen in the current phase, using that as needed to control the > code flow. > > This increases