Re: [PATCH v3 1/1] input: avoid NULL dereference

2023-10-11 Thread Tom Rini
On Tue, Oct 03, 2023 at 03:09:01AM +0200, Heinrich Schuchardt wrote: > Before using the result of env_get("stdin") we must check if it is NULL. > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > need a dummy assignment in the else branch. Anyway this warning is > disa

Re: [PATCH v3 1/1] input: avoid NULL dereference

2023-10-04 Thread Tom Rini
On Tue, Oct 03, 2023 at 03:09:01AM +0200, Heinrich Schuchardt wrote: > Before using the result of env_get("stdin") we must check if it is NULL. > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > need a dummy assignment in the else branch. Anyway this warning is > disa

Re: [PATCH v3 1/1] input: avoid NULL dereference

2023-10-03 Thread Simon Glass
On Mon, 2 Oct 2023 at 19:09, Heinrich Schuchardt wrote: > > Before using the result of env_get("stdin") we must check if it is NULL. > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > need a dummy assignment in the else branch. Anyway this warning is > disabled in the