Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-19 Thread Kunihiko Hayashi
Hi Marek, On 2023/02/18 4:58, Marek Vasut wrote: On 2/16/23 17:14, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, Sorry for late reply. On 2023/02/14 6:06, Marek Vasut wrote: On 2/13/23 04:08, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] I think so, however, wh

Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-17 Thread Marek Vasut
On 2/16/23 17:14, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, Sorry for late reply. On 2023/02/14 6:06, Marek Vasut wrote: On 2/13/23 04:08, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] I think so, however, when I added .exit() and executed "usb stop;usb start

Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-16 Thread Kunihiko Hayashi
Hi Marek, Sorry for late reply. On 2023/02/14 6:06, Marek Vasut wrote: On 2/13/23 04:08, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] I think so, however, when I added .exit() and executed "usb stop;usb start", unfortunately the command got stuck. Currently uniphier clk d

Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-13 Thread Marek Vasut
On 2/13/23 04:08, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/02/10 23:09, Marek Vasut wrote: On 2/8/23 10:15, Kunihiko Hayashi wrote: [...] +static int uniphier_usb3phy_init(struct phy *phy) +{ +    struct uniphier_usb3phy_priv *priv = dev_get_priv(phy->dev); +    int re

Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-12 Thread Kunihiko Hayashi
Hi Marek, On 2023/02/10 23:09, Marek Vasut wrote: On 2/8/23 10:15, Kunihiko Hayashi wrote: [...] +static int uniphier_usb3phy_init(struct phy *phy) +{ + struct uniphier_usb3phy_priv *priv = dev_get_priv(phy->dev); + int ret; + + ret = clk_enable_bulk(&priv->clks); + if

Re: [PATCH v3 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-10 Thread Marek Vasut
On 2/8/23 10:15, Kunihiko Hayashi wrote: [...] +static int uniphier_usb3phy_init(struct phy *phy) +{ + struct uniphier_usb3phy_priv *priv = dev_get_priv(phy->dev); + int ret; + + ret = clk_enable_bulk(&priv->clks); + if (ret) + goto out_clk; This should b