Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-05-02 Thread Simon Glass
Hi Filip, On Tue, 2 May 2023 at 12:43, Filip Žaludek wrote: > > > > Hi Simon, Michal, Marek, > > > > On 4/26/23 03:04, Simon Glass wrote: > > Hi Filip, > > > > On Tue, 25 Apr 2023 at 06:36, Filip Žaludek > > wrote: > >> > >> > >> > >> Hi Simon, > >> > >> > >> On 4/19/23 03:49, Simon Glass wrote

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-05-02 Thread Filip Žaludek
Hi Simon, Michal, Marek, On 4/26/23 03:04, Simon Glass wrote: Hi Filip, On Tue, 25 Apr 2023 at 06:36, Filip Žaludek wrote: Hi Simon, On 4/19/23 03:49, Simon Glass wrote: Hi Filip, On Tue, 11 Apr 2023 at 14:24, Filip Žaludek wrote: On 2/8/23 20:01, Mark Kettenis wrote: Date:

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-04-25 Thread Simon Glass
Hi Filip, On Tue, 25 Apr 2023 at 06:36, Filip Žaludek wrote: > > > > Hi Simon, > > > On 4/19/23 03:49, Simon Glass wrote: > > Hi Filip, > > > > On Tue, 11 Apr 2023 at 14:24, Filip Žaludek > > wrote: > >> > >> > >> > >> On 2/8/23 20:01, Mark Kettenis wrote: > Date: Wed, 8 Feb 2023 19:45:36

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-04-25 Thread Filip Žaludek
Hi Simon, On 4/19/23 03:49, Simon Glass wrote: Hi Filip, On Tue, 11 Apr 2023 at 14:24, Filip Žaludek wrote: On 2/8/23 20:01, Mark Kettenis wrote: Date: Wed, 8 Feb 2023 19:45:36 +0100 From: Michal Suchánek Hello, On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: Hi M

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-04-18 Thread Simon Glass
Hi Filip, On Tue, 11 Apr 2023 at 14:24, Filip Žaludek wrote: > > > > On 2/8/23 20:01, Mark Kettenis wrote: > >> Date: Wed, 8 Feb 2023 19:45:36 +0100 > >> From: Michal Suchánek > >> > >> Hello, > >> > >> On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: > >>> > >>> > >>> Hi Michal, >

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-04-11 Thread Filip Žaludek
On 2/8/23 20:01, Mark Kettenis wrote: Date: Wed, 8 Feb 2023 19:45:36 +0100 From: Michal Suchánek Hello, On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: Hi Michal, thanks for testing! Do you consider keyboard as working once it is detected without 'usb_kbd usb_kbd: Time

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-02-09 Thread Filip Žaludek
Hi, On 2/8/23 19:45, Michal Suchánek wrote: Hello, On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: Hi Michal, thanks for testing! Do you consider keyboard as working once it is detected without 'usb_kbd usb_kbd: Timeout poll on interrupt endpoint', or judging from subs

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-02-08 Thread Mark Kettenis
> Date: Wed, 8 Feb 2023 19:45:36 +0100 > From: Michal Suchánek > > Hello, > > On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: > > > > > > Hi Michal, > > > > thanks for testing! Do you consider keyboard as working once it is > > detected without > > 'usb_kbd usb_kbd: Timeout p

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-02-08 Thread Michal Suchánek
Hello, On Wed, Jan 18, 2023 at 05:01:12PM +0100, Filip Žaludek wrote: > > > Hi Michal, > > thanks for testing! Do you consider keyboard as working once it is detected > without > 'usb_kbd usb_kbd: Timeout poll on interrupt endpoint', or judging from > subsequent > typing? Note that issue is

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-02-08 Thread Simon Glass
Hi Filip, On Wed, 18 Jan 2023 at 09:03, Filip Žaludek wrote: > > > > Hi Michal, > > thanks for testing! Do you consider keyboard as working once it is detected > without > 'usb_kbd usb_kbd: Timeout poll on interrupt endpoint', or judging from > subsequent > typing? Note that issue is reproduc

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-01-18 Thread Filip Žaludek
Hi Michal, thanks for testing! Do you consider keyboard as working once it is detected without 'usb_kbd usb_kbd: Timeout poll on interrupt endpoint', or judging from subsequent typing? Note that issue is reproducible only in about 20% of reboots. For me I can always enter 'U-Boot>' shell, b

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-01-17 Thread Michal Suchánek
Hello, On Sat, Dec 17, 2022 at 01:49:47PM +0100, Filip Žaludek wrote: > > > Hello, > change seems to be unfriendly to RPi3B+, it allows to enter 'U-Boot>' shell > but usb keyboard > does not respond. Keyboard is detected by 'usb info' in v2023.01-rc3, not in > v2022.10. > When reverted, usb k

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-01-03 Thread Simon Glass
Hi Filip, On Mon, 19 Dec 2022 at 14:25, Filip Žaludek wrote: > > > > Hi Simon, > > > On 12/19/22 20:20, Simon Glass wrote: > > Hi Filip, > > > > On Mon, 19 Dec 2022 at 02:29, Filip Žaludek > > wrote: > >> > >> > >> > >> Hi Simon, > >> > >>is your testing framework connected to HDMI? Only no

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-19 Thread Filip Žaludek
Hi Simon, On 12/19/22 20:20, Simon Glass wrote: Hi Filip, On Mon, 19 Dec 2022 at 02:29, Filip Žaludek wrote: Hi Simon, is your testing framework connected to HDMI? Only notable discrepancy from generic config is enabled 'efidebug' command. Tested more (cycled 'U-Boot>' and 'reset

Re: [External] : Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-19 Thread Simon Glass
Hi Filip, On Mon, 19 Dec 2022 at 02:29, Filip Žaludek wrote: > > > > Hi Simon, > > is your testing framework connected to HDMI? Only notable discrepancy > from generic config is enabled 'efidebug' command. > > > Tested more (cycled 'U-Boot>' and 'reset'), both RPi3B and RPi3B+.. > USB Keyboard

Re: [External] : Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-19 Thread Filip Žaludek
Hi Simon, is your testing framework connected to HDMI? Only notable discrepancy from generic config is enabled 'efidebug' command. Tested more (cycled 'U-Boot>' and 'reset'), both RPi3B and RPi3B+.. USB Keyboard failure rates: connected console02/10 connected hdmi

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-12-17 Thread Simon Glass
Hi Filip, On Sat, 17 Dec 2022 at 05:50, Filip Žaludek wrote: > > > > Hello, > change seems to be unfriendly to RPi3B+, it allows to enter 'U-Boot>' shell > but usb keyboard > does not respond. Keyboard is detected by 'usb info' in v2023.01-rc3, not in > v2022.10. > When reverted, usb keyboard

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-02-11 Thread Simon Glass
()Hi Thomas, On Thu, 10 Feb 2022 at 18:43, Thomas Watson wrote: > > > On Feb 10, 2022, at 5:04 PM, Marek Vasut wrote: > > On 2/11/22 00:02, Simon Glass wrote: > > Hi Marek, > On Thu, 10 Feb 2022 at 14:42, Marek Vasut wrote: > > > On 2/10/22 22:13, Thomas Watson wrote: > > Using the XHCI driver,

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-02-10 Thread Marek Vasut
On 2/11/22 00:02, Simon Glass wrote: Hi Marek, On Thu, 10 Feb 2022 at 14:42, Marek Vasut wrote: On 2/10/22 22:13, Thomas Watson wrote: Using the XHCI driver, the function `usb_kbd_poll_for_event` takes 30-40ms to run. The exact time is dependent on the polling interval the keyboard requests

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-02-10 Thread Simon Glass
Hi Marek, On Thu, 10 Feb 2022 at 14:42, Marek Vasut wrote: > > On 2/10/22 22:13, Thomas Watson wrote: > > Using the XHCI driver, the function `usb_kbd_poll_for_event` takes > > 30-40ms to run. The exact time is dependent on the polling interval the > > keyboard requests in its descriptor, and lik

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-02-10 Thread Marek Vasut
On 2/10/22 23:00, Thomas Watson wrote: On Feb 10, 2022, at 3:42 PM, Marek Vasut wrote: On 2/10/22 22:13, Thomas Watson wrote: Using the XHCI driver, the function `usb_kbd_poll_for_event` takes 30-40ms to run. The exact time is dependent on the polling interval the keyboard requests in its de

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2022-02-10 Thread Marek Vasut
On 2/10/22 22:13, Thomas Watson wrote: Using the XHCI driver, the function `usb_kbd_poll_for_event` takes 30-40ms to run. The exact time is dependent on the polling interval the keyboard requests in its descriptor, and likely cannot be significantly reduced without major rework to the XHCI driver