Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-10-25 Thread Tom Rini
On Wed, Oct 25, 2023 at 09:33:03AM +0200, Michal Simek wrote: > > > On 10/24/23 20:03, Tom Rini wrote: > > On Tue, Oct 24, 2023 at 02:33:26PM +0200, Michal Simek wrote: > > > Hi Tom, > > > > > > On 9/25/23 16:33, Tom Rini wrote: > > > > On Mon, Sep 25, 2023 at 04:21:17PM +0200, Michal Simek wrot

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-10-25 Thread Michal Simek
On 10/24/23 20:03, Tom Rini wrote: On Tue, Oct 24, 2023 at 02:33:26PM +0200, Michal Simek wrote: Hi Tom, On 9/25/23 16:33, Tom Rini wrote: On Mon, Sep 25, 2023 at 04:21:17PM +0200, Michal Simek wrote: On 9/25/23 16:19, Tom Rini wrote: On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Sim

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-10-24 Thread Tom Rini
On Tue, Oct 24, 2023 at 02:33:26PM +0200, Michal Simek wrote: > Hi Tom, > > On 9/25/23 16:33, Tom Rini wrote: > > On Mon, Sep 25, 2023 at 04:21:17PM +0200, Michal Simek wrote: > > > > > > > > > On 9/25/23 16:19, Tom Rini wrote: > > > > On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Simek wrote

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-10-24 Thread Michal Simek
Hi Tom, On 9/25/23 16:33, Tom Rini wrote: On Mon, Sep 25, 2023 at 04:21:17PM +0200, Michal Simek wrote: On 9/25/23 16:19, Tom Rini wrote: On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Simek wrote: Hi Simon, On 9/25/23 16:01, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 07:38,

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Michal Simek
On 9/25/23 16:28, Tom Rini wrote: On Mon, Sep 25, 2023 at 08:01:41AM -0600, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: On 9/25/23 15:10, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: Hi Simon, On 9/23/23 20:

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Tom Rini
On Mon, Sep 25, 2023 at 04:21:17PM +0200, Michal Simek wrote: > > > On 9/25/23 16:19, Tom Rini wrote: > > On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Simek wrote: > > > Hi Simon, > > > > > > On 9/25/23 16:01, Simon Glass wrote: > > > > Hi Michal, > > > > > > > > On Mon, 25 Sept 2023 at 07:

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Tom Rini
On Mon, Sep 25, 2023 at 08:01:41AM -0600, Simon Glass wrote: > Hi Michal, > > On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: > > > > > > > > On 9/25/23 15:10, Simon Glass wrote: > > > Hi Michal, > > > > > > On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: > > >> > > >> Hi Simon, > > >> > >

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Michal Simek
On 9/25/23 16:19, Tom Rini wrote: On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Simek wrote: Hi Simon, On 9/25/23 16:01, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: On 9/25/23 15:10, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 00:06,

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Tom Rini
On Mon, Sep 25, 2023 at 04:10:38PM +0200, Michal Simek wrote: > Hi Simon, > > On 9/25/23 16:01, Simon Glass wrote: > > Hi Michal, > > > > On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: > > > > > > > > > > > > On 9/25/23 15:10, Simon Glass wrote: > > > > Hi Michal, > > > > > > > > On Mon,

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Michal Simek
Hi Simon, On 9/25/23 16:01, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: On 9/25/23 15:10, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: Hi Simon, On 9/23/23 20:13, Simon Glass wrote: Current alignment which is

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Simon Glass
Hi Michal, On Mon, 25 Sept 2023 at 07:38, Michal Simek wrote: > > > > On 9/25/23 15:10, Simon Glass wrote: > > Hi Michal, > > > > On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: > >> > >> Hi Simon, > >> > >> > >> On 9/23/23 20:13, Simon Glass wrote: > >>> Current alignment which is using 16 b

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Michal Simek
On 9/25/23 15:10, Simon Glass wrote: Hi Michal, On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: Hi Simon, On 9/23/23 20:13, Simon Glass wrote: Current alignment which is using 16 bytes is not correct in connection to trace_clocks description and it's length. That's why use start_addr

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-25 Thread Simon Glass
Hi Michal, On Mon, 25 Sept 2023 at 00:06, Michal Simek wrote: > > Hi Simon, > > > On 9/23/23 20:13, Simon Glass wrote: > > Current alignment which is using 16 bytes is not correct in connection to > > trace_clocks description and it's length. > > That's why use start_addr variable and record prop

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-24 Thread Michal Simek
Hi Simon, On 9/23/23 20:13, Simon Glass wrote: Current alignment which is using 16 bytes is not correct in connection to trace_clocks description and it's length. That's why use start_addr variable and record proper size based on used entries. Fixes: be16fc81b2ed ("trace: Update proftool to us

Re: [PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

2023-09-23 Thread Simon Glass
Current alignment which is using 16 bytes is not correct in connection to trace_clocks description and it's length. That's why use start_addr variable and record proper size based on used entries. Fixes: be16fc81b2ed ("trace: Update proftool to use new binary format"). Signed-off-by: Michal Simek