Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-10-01 Thread Simon Glass
Hi Ilias, On Tue, 28 Sept 2021 at 11:41, Ilias Apalodimas wrote: > > Hi Simon, > > > [...] > > > > > We've mentioned this in the past. The sandbox TPM is very limited wrt > > > > > tpm testing for the EFI TCG protocol. > > > > > > > > So let's add some more features? If it helps, think of the sa

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-10-01 Thread Masahisa Kojima
On Thu, 23 Sept 2021 at 01:19, Simon Glass wrote: > > Hi Masahisa, > > On Tue, 21 Sept 2021 at 01:17, Masahisa Kojima > wrote: > > > > TCG PC Client spec requires to measure the SMBIOS > > table that contain static configuration information > > (e.g. Platform Manufacturer Enterprise Number assign

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-28 Thread Ilias Apalodimas
Hi Simon, [...] > > > > We've mentioned this in the past. The sandbox TPM is very limited wrt > > > > tpm testing for the EFI TCG protocol. > > > > > > So let's add some more features? If it helps, think of the sandbox TPM > > > as test code, not an emulator. It is a very simple kind of emulator

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-27 Thread Simon Glass
Hi Ilias, On Mon, 27 Sept 2021 at 02:52, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > - remove unnecessary const qualifier from smbios_string() > > > > > - create non-const version of next_header() > > > > > > > > > > include/efi_loader.h | 2 + > > > > > include/efi_tc

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-27 Thread Ilias Apalodimas
Hi Simon, [...] > > > > - remove unnecessary const qualifier from smbios_string() > > > > - create non-const version of next_header() > > > > > > > > include/efi_loader.h | 2 + > > > > include/efi_tcg2.h| 15 > > > > include/smbios.h | 17 +++- > > > >

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-24 Thread Simon Glass
Hi Ilias, On Thu, 23 Sept 2021 at 03:17, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, 22 Sept 2021 at 19:19, Simon Glass wrote: > > > > Hi Masahisa, > > > > On Tue, 21 Sept 2021 at 01:17, Masahisa Kojima > > wrote: > > > > > > TCG PC Client spec requires to measure the SMBIOS > > > table t

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-23 Thread Ilias Apalodimas
Hi Simon, On Wed, 22 Sept 2021 at 19:19, Simon Glass wrote: > > Hi Masahisa, > > On Tue, 21 Sept 2021 at 01:17, Masahisa Kojima > wrote: > > > > TCG PC Client spec requires to measure the SMBIOS > > table that contain static configuration information > > (e.g. Platform Manufacturer Enterprise Nu

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-22 Thread Simon Glass
Hi Masahisa, On Tue, 21 Sept 2021 at 01:17, Masahisa Kojima wrote: > > TCG PC Client spec requires to measure the SMBIOS > table that contain static configuration information > (e.g. Platform Manufacturer Enterprise Number assigned by IANA, > platform model number, Vendor and Device IDs for each